diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-06-18 09:08:00 -0400 |
---|---|---|
committer | Jonathan Cameron <jic23@kernel.org> | 2013-06-29 05:18:21 -0400 |
commit | 94fccb78414a87f3c4bc7049ff8b6e80156944d9 (patch) | |
tree | d3645903037cb92017e61e920731bc599f01e13a /drivers/iio/dac/ad7303.c | |
parent | 0ad1ea69545b1965be4c93ee03fdc685c6beb23d (diff) |
iio: dac: ad7303: fix error return code in ad7303_probe()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/dac/ad7303.c')
-rw-r--r-- | drivers/iio/dac/ad7303.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c index 85aeef60dc5f..d546f50f9258 100644 --- a/drivers/iio/dac/ad7303.c +++ b/drivers/iio/dac/ad7303.c | |||
@@ -235,8 +235,10 @@ static int ad7303_probe(struct spi_device *spi) | |||
235 | 235 | ||
236 | if (ext_ref) { | 236 | if (ext_ref) { |
237 | st->vref_reg = regulator_get(&spi->dev, "REF"); | 237 | st->vref_reg = regulator_get(&spi->dev, "REF"); |
238 | if (IS_ERR(st->vref_reg)) | 238 | if (IS_ERR(st->vref_reg)) { |
239 | ret = PTR_ERR(st->vref_reg); | ||
239 | goto err_disable_vdd_reg; | 240 | goto err_disable_vdd_reg; |
241 | } | ||
240 | 242 | ||
241 | ret = regulator_enable(st->vref_reg); | 243 | ret = regulator_enable(st->vref_reg); |
242 | if (ret) | 244 | if (ret) |