diff options
author | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> | 2014-07-16 20:42:00 -0400 |
---|---|---|
committer | Jonathan Cameron <jic23@kernel.org> | 2014-07-20 11:37:52 -0400 |
commit | c1288b8338815d6d17577b6b6a1267e7be8bc409 (patch) | |
tree | 6337129f4027db5fa070edbf3855f37c5afdbfd9 /drivers/iio/accel | |
parent | 59bfeaba3b62089f98952fe689d44a093275b1a0 (diff) |
iio: accel: kxcjk-1013: Increment ref counter for indio_dev->trig
Assigning indio_dev->trig is not a good idea, as this can result in
wrong reference count for trigger device. If assigned, it is better to
increment reference counter by calling iio_trigger_get.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/accel')
-rw-r--r-- | drivers/iio/accel/kxcjk-1013.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index bff5161a36ce..eb8a3229a9d6 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c | |||
@@ -644,6 +644,7 @@ static int kxcjk1013_probe(struct i2c_client *client, | |||
644 | iio_trigger_set_drvdata(trig, indio_dev); | 644 | iio_trigger_set_drvdata(trig, indio_dev); |
645 | data->trig = trig; | 645 | data->trig = trig; |
646 | indio_dev->trig = trig; | 646 | indio_dev->trig = trig; |
647 | iio_trigger_get(indio_dev->trig); | ||
647 | 648 | ||
648 | ret = iio_trigger_register(trig); | 649 | ret = iio_trigger_register(trig); |
649 | if (ret) | 650 | if (ret) |