diff options
author | Danny Tholen <obiwan@mailmij.org> | 2006-08-27 04:23:29 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-08-27 14:01:28 -0400 |
commit | 7334bb4ae931159384acf168eacb0d5d6e0d083c (patch) | |
tree | acbe6d8634e526c90fa73fc2f44f50f179fcf82f /drivers/ieee1394 | |
parent | a2e0b56316fa90e137802fdad6a7c6a9b85c86c3 (diff) |
[PATCH] 1394: fix for recently added firewire patch that breaks things on ppc
Recently a patch was added for preliminary suspend/resume handling on
!PPC_PMAC. However, this broke both suspend and firewire on powerpc
because it saves the pci state after the device has already been disabled.
This moves the save state to before the pmac specific code.
Signed-off-by: Danny Tholen <obiwan@mailmij.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Ben Collins <bcollins@ubuntu.com>
Cc: Jody McIntyre <scjody@modernduck.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/ieee1394')
-rw-r--r-- | drivers/ieee1394/ohci1394.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ieee1394/ohci1394.c b/drivers/ieee1394/ohci1394.c index d4bad6704bbe..448df2773377 100644 --- a/drivers/ieee1394/ohci1394.c +++ b/drivers/ieee1394/ohci1394.c | |||
@@ -3552,6 +3552,8 @@ static int ohci1394_pci_resume (struct pci_dev *pdev) | |||
3552 | 3552 | ||
3553 | static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state) | 3553 | static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state) |
3554 | { | 3554 | { |
3555 | pci_save_state(pdev); | ||
3556 | |||
3555 | #ifdef CONFIG_PPC_PMAC | 3557 | #ifdef CONFIG_PPC_PMAC |
3556 | if (machine_is(powermac)) { | 3558 | if (machine_is(powermac)) { |
3557 | struct device_node *of_node; | 3559 | struct device_node *of_node; |
@@ -3563,8 +3565,6 @@ static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state) | |||
3563 | } | 3565 | } |
3564 | #endif | 3566 | #endif |
3565 | 3567 | ||
3566 | pci_save_state(pdev); | ||
3567 | |||
3568 | return 0; | 3568 | return 0; |
3569 | } | 3569 | } |
3570 | 3570 | ||