aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ieee1394
diff options
context:
space:
mode:
authorVegard Nossum <vegard.nossum@gmail.com>2008-09-11 14:59:03 -0400
committerVegard Nossum <vegard.nossum@gmail.com>2009-06-15 09:49:31 -0400
commit96c25c81ecf452b778e2f432bd17c95de637d129 (patch)
tree813f07c6ae1aa38b9bf41cfc6a19e76a6b561817 /drivers/ieee1394
parent004cdb5a718fa2bb697c541eb1171ee817fc72f1 (diff)
ieee1394/csr1212: fix false positive kmemcheck report
kmemcheck reports a use of uninitialized memory here, but it's not a real error. The structure in question has just been allocated, and the whole field is initialized, but it happens in two steps. We fix the false positive by inserting a kmemcheck annotation. Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Diffstat (limited to 'drivers/ieee1394')
-rw-r--r--drivers/ieee1394/csr1212.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/ieee1394/csr1212.c b/drivers/ieee1394/csr1212.c
index a6dfeb0b3372..e76cac64c533 100644
--- a/drivers/ieee1394/csr1212.c
+++ b/drivers/ieee1394/csr1212.c
@@ -35,6 +35,7 @@
35 35
36#include <linux/errno.h> 36#include <linux/errno.h>
37#include <linux/kernel.h> 37#include <linux/kernel.h>
38#include <linux/kmemcheck.h>
38#include <linux/string.h> 39#include <linux/string.h>
39#include <asm/bug.h> 40#include <asm/bug.h>
40#include <asm/byteorder.h> 41#include <asm/byteorder.h>
@@ -387,6 +388,7 @@ csr1212_new_descriptor_leaf(u8 dtype, u32 specifier_id,
387 if (!kv) 388 if (!kv)
388 return NULL; 389 return NULL;
389 390
391 kmemcheck_annotate_variable(kv->value.leaf.data[0]);
390 CSR1212_DESCRIPTOR_LEAF_SET_TYPE(kv, dtype); 392 CSR1212_DESCRIPTOR_LEAF_SET_TYPE(kv, dtype);
391 CSR1212_DESCRIPTOR_LEAF_SET_SPECIFIER_ID(kv, specifier_id); 393 CSR1212_DESCRIPTOR_LEAF_SET_SPECIFIER_ID(kv, specifier_id);
392 394