aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ieee1394/sbp2.c
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-14 20:00:11 -0400
committerStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-19 07:01:41 -0400
commit5030c807907ae90ad21e9220c1a9d592558deba2 (patch)
tree4bb37dffd32a71e9c7712df14938af6bb73656c7 /drivers/ieee1394/sbp2.c
parent0fcff4e39323f466a47684d7c8ffa77e1be86c8a (diff)
ieee1394: remove unused variables
which caused gcc 4.6 to warn about variable 'XYZ' set but not used. sbp2.c, unit_characteristics: The underlying problem which was spotted here --- an incomplete implementation --- is already 50% fixed in drivers/firewire/sbp2.c which observes mgt_ORB_timeout but not yet ORB_size. raw1394.c, length_conflict; dv1394.c, ts_off: Impossible to tell why these variables are there. We can safely remove them though because we don't need a compiler warning to realize that we are dealing with (at least stylistically) flawed code here. dv1394.c, packet_time: This was used in debug macro that is only compiled in with DV1394_DEBUG_LEVEL >= 2 defined at compile-time. Just drop it since nobody debugs dv1394 anymore. Avoids noise in regular kernel builds. dv1394.c, ohci; eth1394.c, priv: These variables clearly can go away. Somebody wanted to use them but then didn't (or not anymore). Note, all of this code is considered to be at its end of life and is thus not really meant to receive janitorial updates anymore. But if we can easily remove noisy warnings from kernel builds, we should. Reported-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/ieee1394/sbp2.c')
-rw-r--r--drivers/ieee1394/sbp2.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index f199896c4113..d3a136c70c48 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -1351,12 +1351,11 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
1351 struct csr1212_keyval *kv; 1351 struct csr1212_keyval *kv;
1352 struct csr1212_dentry *dentry; 1352 struct csr1212_dentry *dentry;
1353 u64 management_agent_addr; 1353 u64 management_agent_addr;
1354 u32 unit_characteristics, firmware_revision, model; 1354 u32 firmware_revision, model;
1355 unsigned workarounds; 1355 unsigned workarounds;
1356 int i; 1356 int i;
1357 1357
1358 management_agent_addr = 0; 1358 management_agent_addr = 0;
1359 unit_characteristics = 0;
1360 firmware_revision = SBP2_ROM_VALUE_MISSING; 1359 firmware_revision = SBP2_ROM_VALUE_MISSING;
1361 model = ud->flags & UNIT_DIRECTORY_MODEL_ID ? 1360 model = ud->flags & UNIT_DIRECTORY_MODEL_ID ?
1362 ud->model_id : SBP2_ROM_VALUE_MISSING; 1361 ud->model_id : SBP2_ROM_VALUE_MISSING;
@@ -1373,17 +1372,15 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
1373 lu->lun = ORB_SET_LUN(kv->value.immediate); 1372 lu->lun = ORB_SET_LUN(kv->value.immediate);
1374 break; 1373 break;
1375 1374
1376 case SBP2_UNIT_CHARACTERISTICS_KEY:
1377 /* FIXME: This is ignored so far.
1378 * See SBP-2 clause 7.4.8. */
1379 unit_characteristics = kv->value.immediate;
1380 break;
1381 1375
1382 case SBP2_FIRMWARE_REVISION_KEY: 1376 case SBP2_FIRMWARE_REVISION_KEY:
1383 firmware_revision = kv->value.immediate; 1377 firmware_revision = kv->value.immediate;
1384 break; 1378 break;
1385 1379
1386 default: 1380 default:
1381 /* FIXME: Check for SBP2_UNIT_CHARACTERISTICS_KEY
1382 * mgt_ORB_timeout and ORB_size, SBP-2 clause 7.4.8. */
1383
1387 /* FIXME: Check for SBP2_DEVICE_TYPE_AND_LUN_KEY. 1384 /* FIXME: Check for SBP2_DEVICE_TYPE_AND_LUN_KEY.
1388 * Its "ordered" bit has consequences for command ORB 1385 * Its "ordered" bit has consequences for command ORB
1389 * list handling. See SBP-2 clauses 4.6, 7.4.11, 10.2 */ 1386 * list handling. See SBP-2 clauses 4.6, 7.4.11, 10.2 */