diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-01-25 16:35:47 -0500 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-02-08 14:59:54 -0500 |
commit | beb2fdcad14af14fa38d5098003bd0f53e1c1185 (patch) | |
tree | 031091f1600cd5e800cd7b527201deb6dd205b48 /drivers/ieee1394/sbp2.c | |
parent | 9c31b387234287917023e64d1f11aedfd2685dd9 (diff) |
ieee1394: sbp2: lower block queue alignment requirement
The old setting is copy & waste from usb-storage and doesn't apply to
sbp2. There is only 4-byte alignment required for everything, except
for S/G table elements which have to be 8-byte aligned according to the
SBP-2 spec. (They happen to be ____cacheline_aligned in our
implementation. Whether that's good is another question.)
We now simply don't tune block queue alignment at all. The default
alignment would surely never become anything else than a multiple of 4,
else tons of calls to blk_queue_dma_alignment would have to be added
everywhere in drivers/...
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/ieee1394/sbp2.c')
-rw-r--r-- | drivers/ieee1394/sbp2.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 36d7b06932aa..4edfff46b1e6 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c | |||
@@ -51,7 +51,6 @@ | |||
51 | * Grep for inline FIXME comments below. | 51 | * Grep for inline FIXME comments below. |
52 | */ | 52 | */ |
53 | 53 | ||
54 | #include <linux/blkdev.h> | ||
55 | #include <linux/compiler.h> | 54 | #include <linux/compiler.h> |
56 | #include <linux/delay.h> | 55 | #include <linux/delay.h> |
57 | #include <linux/device.h> | 56 | #include <linux/device.h> |
@@ -2012,7 +2011,6 @@ static int sbp2scsi_slave_configure(struct scsi_device *sdev) | |||
2012 | { | 2011 | { |
2013 | struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0]; | 2012 | struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0]; |
2014 | 2013 | ||
2015 | blk_queue_dma_alignment(sdev->request_queue, (512 - 1)); | ||
2016 | sdev->use_10_for_rw = 1; | 2014 | sdev->use_10_for_rw = 1; |
2017 | 2015 | ||
2018 | if (sdev->type == TYPE_ROM) | 2016 | if (sdev->type == TYPE_ROM) |