diff options
author | Jeff Garzik <jgarzik@pobox.com> | 2005-05-28 07:47:39 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2005-06-17 13:04:37 -0400 |
commit | e3df715501be3329986e5d9dfa9a477f49e7996b (patch) | |
tree | 3602c4bbca8bca9b615b93099de53717bc932591 /drivers/ieee1394/sbp2.c | |
parent | 12021fff2bae7fab01c4bf283f3cd9bc6997d8c4 (diff) |
[SCSI] Remove unnecessary locking around completion function calls
The SCSI ->done() hook should not be called from inside a spinlock.
Drivers that do this are mostly cut-n-paste from 2.2.x-era.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/ieee1394/sbp2.c')
-rw-r--r-- | drivers/ieee1394/sbp2.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index aa941025072e..de552486b1c9 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c | |||
@@ -2453,8 +2453,6 @@ static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id, | |||
2453 | u32 scsi_status, struct scsi_cmnd *SCpnt, | 2453 | u32 scsi_status, struct scsi_cmnd *SCpnt, |
2454 | void (*done)(struct scsi_cmnd *)) | 2454 | void (*done)(struct scsi_cmnd *)) |
2455 | { | 2455 | { |
2456 | unsigned long flags; | ||
2457 | |||
2458 | SBP2_DEBUG("sbp2scsi_complete_command"); | 2456 | SBP2_DEBUG("sbp2scsi_complete_command"); |
2459 | 2457 | ||
2460 | /* | 2458 | /* |
@@ -2553,11 +2551,7 @@ static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id, | |||
2553 | /* | 2551 | /* |
2554 | * Tell scsi stack that we're done with this command | 2552 | * Tell scsi stack that we're done with this command |
2555 | */ | 2553 | */ |
2556 | spin_lock_irqsave(scsi_id->scsi_host->host_lock,flags); | ||
2557 | done (SCpnt); | 2554 | done (SCpnt); |
2558 | spin_unlock_irqrestore(scsi_id->scsi_host->host_lock,flags); | ||
2559 | |||
2560 | return; | ||
2561 | } | 2555 | } |
2562 | 2556 | ||
2563 | 2557 | ||