ieee1394: eth1394: don't autoload by hotplug when ohci1394 starts

Until now, ieee1394 put an IP-over-1394 capability entry into each new
host's config ROM.  As soon as the controller was initialized --- i.e.
right after modprobe ohci1394 --- this entry triggered a hotplug event
which typically caused auto-loading of eth1394.

This irritated or annoyed many users and distributors.  Of course they
could blacklist eth1394, but then ieee1394 wrongly advertized IP-over-
1394 capability to the FireWire bus.

Therefore
  - remove the offending kernel config option
    IEEE1394_CONFIG_ROM_IP1394,
  - let eth1394 add the ROM entry by itself, i.e. only after eth1394 was
    loaded.

This fixes http://bugzilla.kernel.org/show_bug.cgi?id=7793 .

To emulate the behaviour of older kernels, simply add the following to
to /etc/modprobe.conf:

install ohci1394 /sbin/modprobe eth1394; \
                 /sbin/modprobe --ignore-install ohci1394

Note, autoloading of eth1394 when an _external_ IP-over-1394 capable
device is discovered is _not_ affected by this patch.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

1 files changed, 6 insertions, 1 deletions

diff --git a/drivers/ieee1394/eth1394.c b/drivers/ieee1394/eth1394.c
index d056c5953be3..b4fa754bfd1a 100644
--- a/drivers/ieee1394/eth1394.c
+++ b/drivers/ieee1394/eth1394.c
@@ -561,8 +561,10 @@ static void ether1394_add_host (struct hpsb_host *host)
         struct eth1394_priv *priv;
         u64 fifo_addr;
 
-        if (!(host->config_roms & HPSB_CONFIG_ROM_ENTRY_IP1394))
+        if (hpsb_config_rom_ip1394_add(host) != 0) {
+                ETH1394_PRINT_G(KERN_ERR, "Can't add IP-over-1394 ROM entry\n");
                 return;
+        }
 
         fifo_addr = hpsb_allocate_and_register_addrspace(
                         &eth1394_highlevel, host, &addr_ops,
@@ -570,6 +572,7 @@ static void ether1394_add_host (struct hpsb_host *host)
                         CSR1212_INVALID_ADDR_SPACE, CSR1212_INVALID_ADDR_SPACE);
         if (fifo_addr == CSR1212_INVALID_ADDR_SPACE) {
                 ETH1394_PRINT_G(KERN_ERR, "Cannot register CSR space\n");
+                hpsb_config_rom_ip1394_remove(host);
                 return;
         }
 
@@ -649,6 +652,7 @@ out:
         if (hi)
                 hpsb_destroy_hostinfo(&eth1394_highlevel, host);
         hpsb_unregister_addrspace(&eth1394_highlevel, host, fifo_addr);
+        hpsb_config_rom_ip1394_remove(host);
 }
 
 /* Remove a card from our list */
@@ -662,6 +666,7 @@ static void ether1394_remove_host (struct hpsb_host *host)
                 return;
         priv = netdev_priv(hi->dev);
         hpsb_unregister_addrspace(&eth1394_highlevel, host, priv->local_fifo);
+        hpsb_config_rom_ip1394_remove(host);
         if (priv->iso)
                 hpsb_iso_shutdown(priv->iso);
         unregister_netdev(hi->dev);