diff options
author | Christoph Hellwig <hch@lst.de> | 2010-06-19 11:26:47 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-08-07 12:22:29 -0400 |
commit | 4c4762d10faf93167b84ee03e4b58dd62012b06f (patch) | |
tree | 5819c7acb3e457885e77edf124196e62b09fd387 /drivers/ide | |
parent | 15fa6e81650a167f82dc0d478f290f1cffa9183d (diff) |
block: fix some more cmd_type cleanup fallout
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/ide')
-rw-r--r-- | drivers/ide/ide-atapi.c | 6 | ||||
-rw-r--r-- | drivers/ide/ide-cd.c | 4 | ||||
-rw-r--r-- | drivers/ide/ide-io.c | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c index 3117a894d20e..e88a2cf17711 100644 --- a/drivers/ide/ide-atapi.c +++ b/drivers/ide/ide-atapi.c | |||
@@ -307,7 +307,7 @@ EXPORT_SYMBOL_GPL(ide_cd_expiry); | |||
307 | 307 | ||
308 | int ide_cd_get_xferlen(struct request *rq) | 308 | int ide_cd_get_xferlen(struct request *rq) |
309 | { | 309 | { |
310 | switch (rq->cmd_type) | 310 | switch (rq->cmd_type) { |
311 | case REQ_TYPE_FS: | 311 | case REQ_TYPE_FS: |
312 | return 32768; | 312 | return 32768; |
313 | case REQ_TYPE_SENSE: | 313 | case REQ_TYPE_SENSE: |
@@ -477,12 +477,12 @@ static ide_startstop_t ide_pc_intr(ide_drive_t *drive) | |||
477 | if (uptodate == 0) | 477 | if (uptodate == 0) |
478 | drive->failed_pc = NULL; | 478 | drive->failed_pc = NULL; |
479 | 479 | ||
480 | if (rq->cmd_type == REQ_TYPE_SPECIAL) | 480 | if (rq->cmd_type == REQ_TYPE_SPECIAL) { |
481 | rq->errors = 0; | 481 | rq->errors = 0; |
482 | error = 0; | 482 | error = 0; |
483 | } else { | 483 | } else { |
484 | 484 | ||
485 | if (req->cmd_type != REQ_TYPE_FS && uptodate <= 0) { | 485 | if (rq->cmd_type != REQ_TYPE_FS && uptodate <= 0) { |
486 | if (rq->errors == 0) | 486 | if (rq->errors == 0) |
487 | rq->errors = -EIO; | 487 | rq->errors = -EIO; |
488 | } | 488 | } |
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 26a3688de467..ef7e3a9bee51 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c | |||
@@ -318,7 +318,7 @@ static int cdrom_decode_status(ide_drive_t *drive, u8 stat) | |||
318 | cdrom_saw_media_change(drive); | 318 | cdrom_saw_media_change(drive); |
319 | 319 | ||
320 | if (rq->cmd_type == REQ_TYPE_FS && | 320 | if (rq->cmd_type == REQ_TYPE_FS && |
321 | !(rq->cmd_flags & REQ_QUIET)) { | 321 | !(rq->cmd_flags & REQ_QUIET)) |
322 | printk(KERN_ERR PFX "%s: tray open\n", | 322 | printk(KERN_ERR PFX "%s: tray open\n", |
323 | drive->name); | 323 | drive->name); |
324 | } | 324 | } |
@@ -375,7 +375,7 @@ static int cdrom_decode_status(ide_drive_t *drive, u8 stat) | |||
375 | do_end_request = 1; | 375 | do_end_request = 1; |
376 | break; | 376 | break; |
377 | default: | 377 | default: |
378 | if (req->cmd_type != REQ_TYPE_FS) | 378 | if (rq->cmd_type != REQ_TYPE_FS) |
379 | break; | 379 | break; |
380 | if (err & ~ATA_ABORTED) { | 380 | if (err & ~ATA_ABORTED) { |
381 | /* go to the default handler for other errors */ | 381 | /* go to the default handler for other errors */ |
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 9304a7e54d9e..a381be814070 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c | |||
@@ -353,7 +353,7 @@ static ide_startstop_t start_request (ide_drive_t *drive, struct request *rq) | |||
353 | pm->pm_step == IDE_PM_COMPLETED) | 353 | pm->pm_step == IDE_PM_COMPLETED) |
354 | ide_complete_pm_rq(drive, rq); | 354 | ide_complete_pm_rq(drive, rq); |
355 | return startstop; | 355 | return startstop; |
356 | } else if (!rq->rq_disk && rq->cmd_type == REQ_TYPE_SPECIAL) { | 356 | } else if (!rq->rq_disk && rq->cmd_type == REQ_TYPE_SPECIAL) |
357 | /* | 357 | /* |
358 | * TODO: Once all ULDs have been modified to | 358 | * TODO: Once all ULDs have been modified to |
359 | * check for specific op codes rather than | 359 | * check for specific op codes rather than |