Merge branch 'upstream'

12 files changed, 101 insertions, 88 deletions

diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 3325660f7248..b4a41d6d0714 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -313,6 +313,7 @@
 #include <linux/cdrom.h>
 #include <linux/ide.h>
 #include <linux/completion.h>
+#include <linux/mutex.h>
 
 #include <scsi/scsi.h>  /* For SCSI -> ATAPI command conversion */
 
@@ -324,7 +325,7 @@
 
 #include "ide-cd.h"
 
-static DECLARE_MUTEX(idecd_ref_sem);
+static DEFINE_MUTEX(idecd_ref_mutex);
 
 #define to_ide_cd(obj) container_of(obj, struct cdrom_info, kref) 
 
@@ -335,11 +336,11 @@ static struct cdrom_info *ide_cd_get(struct gendisk *disk)
 {
         struct cdrom_info *cd = NULL;
 
-        down(&idecd_ref_sem);
+        mutex_lock(&idecd_ref_mutex);
         cd = ide_cd_g(disk);
         if (cd)
                 kref_get(&cd->kref);
-        up(&idecd_ref_sem);
+        mutex_unlock(&idecd_ref_mutex);
         return cd;
 }
 
@@ -347,9 +348,9 @@ static void ide_cd_release(struct kref *);
 
 static void ide_cd_put(struct cdrom_info *cd)
 {
-        down(&idecd_ref_sem);
+        mutex_lock(&idecd_ref_mutex);
         kref_put(&cd->kref, ide_cd_release);
-        up(&idecd_ref_sem);
+        mutex_unlock(&idecd_ref_mutex);
 }
 
 /****************************************************************************
@@ -2142,6 +2143,7 @@ static int cdrom_read_capacity(ide_drive_t *drive, unsigned long *capacity,
         req.cmd[0] = GPCMD_READ_CDVD_CAPACITY;
         req.data = (char *)&capbuf;
         req.data_len = sizeof(capbuf);
+        req.flags |= REQ_QUIET;
 
         stat = cdrom_queue_packet_command(drive, &req);
         if (stat == 0) {
@@ -2471,52 +2473,6 @@ static int ide_cdrom_packet(struct cdrom_device_info *cdi,
 }
 
 static
-int ide_cdrom_dev_ioctl (struct cdrom_device_info *cdi,
-                         unsigned int cmd, unsigned long arg)
-{
-        struct packet_command cgc;
-        char buffer[16];
-        int stat;
-
-        init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_UNKNOWN);
-
-        /* These will be moved into the Uniform layer shortly... */
-        switch (cmd) {
-        case CDROMSETSPINDOWN: {
-                char spindown;
- 
-                if (copy_from_user(&spindown, (void __user *) arg, sizeof(char)))
-                        return -EFAULT;
- 
-                if ((stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0)))
-                        return stat;
-
-                buffer[11] = (buffer[11] & 0xf0) | (spindown & 0x0f);
-
-                return cdrom_mode_select(cdi, &cgc);
-        } 
- 
-        case CDROMGETSPINDOWN: {
-                char spindown;
- 
-                if ((stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0)))
-                        return stat;
- 
-                spindown = buffer[11] & 0x0f;
- 
-                if (copy_to_user((void __user *) arg, &spindown, sizeof (char)))
-                        return -EFAULT;
- 
-                return 0;
-        }
-  
-        default:
-                return -EINVAL;
-        }
-
-}
-
-static
 int ide_cdrom_audio_ioctl (struct cdrom_device_info *cdi,
                            unsigned int cmd, void *arg)
                            
@@ -2852,12 +2808,11 @@ static struct cdrom_device_ops ide_cdrom_dops = {
         .get_mcn                = ide_cdrom_get_mcn,
         .reset                  = ide_cdrom_reset,
         .audio_ioctl            = ide_cdrom_audio_ioctl,
-        .dev_ioctl              = ide_cdrom_dev_ioctl,
         .capability             = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK |
                                 CDC_SELECT_SPEED | CDC_SELECT_DISC |
                                 CDC_MULTI_SESSION | CDC_MCN |
                                 CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO | CDC_RESET |
-                                CDC_IOCTLS | CDC_DRIVE_STATUS | CDC_CD_R |
+                                CDC_DRIVE_STATUS | CDC_CD_R |
                                 CDC_CD_RW | CDC_DVD | CDC_DVD_R| CDC_DVD_RAM |
                                 CDC_GENERIC_PACKET | CDC_MO_DRIVE | CDC_MRW |
                                 CDC_MRW_W | CDC_RAM,
@@ -3367,6 +3322,45 @@ static int idecd_release(struct inode * inode, struct file * file)
         return 0;
 }
 
+static int idecd_set_spindown(struct cdrom_device_info *cdi, unsigned long arg)
+{
+        struct packet_command cgc;
+        char buffer[16];
+        int stat;
+        char spindown;
+
+        if (copy_from_user(&spindown, (void __user *)arg, sizeof(char)))
+                return -EFAULT;
+
+        init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_UNKNOWN);
+
+        stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0);
+        if (stat)
+                return stat;
+
+        buffer[11] = (buffer[11] & 0xf0) | (spindown & 0x0f);
+        return cdrom_mode_select(cdi, &cgc);
+}
+
+static int idecd_get_spindown(struct cdrom_device_info *cdi, unsigned long arg)
+{
+        struct packet_command cgc;
+        char buffer[16];
+        int stat;
+        char spindown;
+
+        init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_UNKNOWN);
+
+        stat = cdrom_mode_sense(cdi, &cgc, GPMODE_CDROM_PAGE, 0);
+        if (stat)
+                return stat;
+
+        spindown = buffer[11] & 0x0f;
+        if (copy_to_user((void __user *)arg, &spindown, sizeof (char)))
+                return -EFAULT;
+        return 0;
+}
+
 static int idecd_ioctl (struct inode *inode, struct file *file,
                         unsigned int cmd, unsigned long arg)
 {
@@ -3374,7 +3368,16 @@ static int idecd_ioctl (struct inode *inode, struct file *file,
         struct cdrom_info *info = ide_cd_g(bdev->bd_disk);
         int err;
 
-        err  = generic_ide_ioctl(info->drive, file, bdev, cmd, arg);
+        switch (cmd) {
+        case CDROMSETSPINDOWN:
+                return idecd_set_spindown(&info->devinfo, arg);
+        case CDROMGETSPINDOWN:
+                return idecd_get_spindown(&info->devinfo, arg);
+        default:
+                break;
+        }
+
+        err = generic_ide_ioctl(info->drive, file, bdev, cmd, arg);
         if (err == -EINVAL)
                 err = cdrom_ioctl(file, &info->devinfo, inode, cmd, arg);
 
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 09086b8b6486..ccf528d733bf 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -60,6 +60,7 @@
 #include <linux/genhd.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/mutex.h>
 
 #define _IDE_DISK
 
@@ -78,7 +79,7 @@ struct ide_disk_obj {
         struct kref     kref;
 };
 
-static DECLARE_MUTEX(idedisk_ref_sem);
+static DEFINE_MUTEX(idedisk_ref_mutex);
 
 #define to_ide_disk(obj) container_of(obj, struct ide_disk_obj, kref)
 
@@ -89,11 +90,11 @@ static struct ide_disk_obj *ide_disk_get(struct gendisk *disk)
 {
         struct ide_disk_obj *idkp = NULL;
 
-        down(&idedisk_ref_sem);
+        mutex_lock(&idedisk_ref_mutex);
         idkp = ide_disk_g(disk);
         if (idkp)
                 kref_get(&idkp->kref);
-        up(&idedisk_ref_sem);
+        mutex_unlock(&idedisk_ref_mutex);
         return idkp;
 }
 
@@ -101,9 +102,9 @@ static void ide_disk_release(struct kref *);
 
 static void ide_disk_put(struct ide_disk_obj *idkp)
 {
-        down(&idedisk_ref_sem);
+        mutex_lock(&idedisk_ref_mutex);
         kref_put(&idkp->kref, ide_disk_release);
-        up(&idedisk_ref_sem);
+        mutex_unlock(&idedisk_ref_mutex);
 }
 
 /*
@@ -977,8 +978,6 @@ static void idedisk_setup (ide_drive_t *drive)
                 ide_dma_verbose(drive);
         printk("\n");
 
-        drive->no_io_32bit = id->dword_io ? 1 : 0;
-
         /* write cache enabled? */
         if ((id->csfo & 1) || (id->cfs_enable_1 & (1 << 5)))
                 drive->wcache = 1;
diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
index 0523da77425a..c481be8b807f 100644
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -175,7 +175,7 @@ ide_startstop_t ide_dma_intr (ide_drive_t *drive)
                         if (rq->rq_disk) {
                                 ide_driver_t *drv;
 
-                                drv = *(ide_driver_t **)rq->rq_disk->private_data;;
+                                drv = *(ide_driver_t **)rq->rq_disk->private_data;
                                 drv->end_request(drive, 1, rq->nr_sectors);
                         } else
                                 ide_end_request(drive, 1, rq->nr_sectors);
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 1f8db9ac05d1..a53e3ce4a142 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -98,6 +98,7 @@
 #include <linux/cdrom.h>
 #include <linux/ide.h>
 #include <linux/bitops.h>
+#include <linux/mutex.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -517,7 +518,7 @@ typedef struct {
         u8              reserved[4];
 } idefloppy_mode_parameter_header_t;
 
-static DECLARE_MUTEX(idefloppy_ref_sem);
+static DEFINE_MUTEX(idefloppy_ref_mutex);
 
 #define to_ide_floppy(obj) container_of(obj, struct ide_floppy_obj, kref)
 
@@ -528,11 +529,11 @@ static struct ide_floppy_obj *ide_floppy_get(struct gendisk *disk)
 {
         struct ide_floppy_obj *floppy = NULL;
 
-        down(&idefloppy_ref_sem);
+        mutex_lock(&idefloppy_ref_mutex);
         floppy = ide_floppy_g(disk);
         if (floppy)
                 kref_get(&floppy->kref);
-        up(&idefloppy_ref_sem);
+        mutex_unlock(&idefloppy_ref_mutex);
         return floppy;
 }
 
@@ -540,9 +541,9 @@ static void ide_floppy_release(struct kref *);
 
 static void ide_floppy_put(struct ide_floppy_obj *floppy)
 {
-        down(&idefloppy_ref_sem);
+        mutex_lock(&idefloppy_ref_mutex);
         kref_put(&floppy->kref, ide_floppy_release);
-        up(&idefloppy_ref_sem);
+        mutex_unlock(&idefloppy_ref_mutex);
 }
 
 /*
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 427d1c204174..1b7b4c531bc2 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -858,6 +858,15 @@ static void probe_hwif(ide_hwif_t *hwif)
                         }
                 }
         }
+
+        for (unit = 0; unit < MAX_DRIVES; ++unit) {
+                ide_drive_t *drive = &hwif->drives[unit];
+
+                if (hwif->no_io_32bit)
+                        drive->no_io_32bit = 1;
+                else
+                        drive->no_io_32bit = drive->id->dword_io ? 1 : 0;
+        }
 }
 
 static int hwif_init(ide_hwif_t *hwif);
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 0101d0def7c5..f04791a58df0 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -433,6 +433,7 @@
 #include <linux/timer.h>
 #include <linux/mm.h>
 #include <linux/interrupt.h>
+#include <linux/jiffies.h>
 #include <linux/major.h>
 #include <linux/devfs_fs_kernel.h>
 #include <linux/errno.h>
@@ -443,6 +444,7 @@
 #include <linux/smp_lock.h>
 #include <linux/completion.h>
 #include <linux/bitops.h>
+#include <linux/mutex.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
@@ -1011,7 +1013,7 @@ typedef struct ide_tape_obj {
          int debug_level; 
 } idetape_tape_t;
 
-static DECLARE_MUTEX(idetape_ref_sem);
+static DEFINE_MUTEX(idetape_ref_mutex);
 
 static struct class *idetape_sysfs_class;
 
@@ -1024,11 +1026,11 @@ static struct ide_tape_obj *ide_tape_get(struct gendisk *disk)
 {
         struct ide_tape_obj *tape = NULL;
 
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         tape = ide_tape_g(disk);
         if (tape)
                 kref_get(&tape->kref);
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
         return tape;
 }
 
@@ -1036,9 +1038,9 @@ static void ide_tape_release(struct kref *);
 
 static void ide_tape_put(struct ide_tape_obj *tape)
 {
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         kref_put(&tape->kref, ide_tape_release);
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
 }
 
 /*
@@ -1290,11 +1292,11 @@ static struct ide_tape_obj *ide_tape_chrdev_get(unsigned int i)
 {
         struct ide_tape_obj *tape = NULL;
 
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         tape = idetape_devs[i];
         if (tape)
                 kref_get(&tape->kref);
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
         return tape;
 }
 
@@ -2335,7 +2337,7 @@ static ide_startstop_t idetape_rw_callback (ide_drive_t *drive)
         }
         if (time_after(jiffies, tape->insert_time))
                 tape->insert_speed = tape->insert_size / 1024 * HZ / (jiffies - tape->insert_time);
-        if (jiffies - tape->avg_time >= HZ) {
+        if (time_after_eq(jiffies, tape->avg_time + HZ)) {
                 tape->avg_speed = tape->avg_size * HZ / (jiffies - tape->avg_time) / 1024;
                 tape->avg_size = 0;
                 tape->avg_time = jiffies;
@@ -2496,7 +2498,7 @@ static ide_startstop_t idetape_do_request(ide_drive_t *drive,
                         } else {
                                 return ide_do_reset(drive);
                         }
-                } else if (jiffies - tape->dsc_polling_start > IDETAPE_DSC_MA_THRESHOLD)
+                } else if (time_after(jiffies, tape->dsc_polling_start + IDETAPE_DSC_MA_THRESHOLD))
                         tape->dsc_polling_frequency = IDETAPE_DSC_MA_SLOW;
                 idetape_postpone_request(drive);
                 return ide_stopped;
@@ -4870,11 +4872,11 @@ static int ide_tape_probe(ide_drive_t *drive)
 
         drive->driver_data = tape;
 
-        down(&idetape_ref_sem);
+        mutex_lock(&idetape_ref_mutex);
         for (minor = 0; idetape_devs[minor]; minor++)
                 ;
         idetape_devs[minor] = tape;
-        up(&idetape_ref_sem);
+        mutex_unlock(&idetape_ref_mutex);
 
         idetape_setup(drive, tape, minor);
 
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index b2cc43702f65..3fdab563fec2 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -2058,7 +2058,7 @@ static void __init parse_options (char *line)
         }
 }
 
-int init_module (void)
+int __init init_module (void)
 {
         parse_options(options);
         return ide_init();
diff --git a/drivers/ide/pci/amd74xx.c b/drivers/ide/pci/amd74xx.c
index 21965e5ef25e..b22ee5462318 100644
--- a/drivers/ide/pci/amd74xx.c
+++ b/drivers/ide/pci/amd74xx.c
@@ -347,10 +347,8 @@ static unsigned int __devinit init_chipset_amd74xx(struct pci_dev *dev, const ch
                         break;
 
                 case AMD_UDMA_66:
-                        pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
-                        for (i = 24; i >= 0; i -= 8)
-                                if ((u >> i) & 4)
-                                        amd_80w |= (1 << (1 - (i >> 4)));
+                        /* no host side cable detection */
+                        amd_80w = 0x03;
                         break;
         }
 
@@ -386,8 +384,6 @@ static unsigned int __devinit init_chipset_amd74xx(struct pci_dev *dev, const ch
         if (amd_clock < 20000 || amd_clock > 50000) {
                 printk(KERN_WARNING "%s: User given PCI clock speed impossible (%d), using 33 MHz instead.\n",
                         amd_chipset->name, amd_clock);
-                printk(KERN_WARNING "%s: Use ide0=ata66 if you want to assume 80-wire cable\n",
-                        amd_chipset->name);
                 amd_clock = 33333;
         }
 
diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c
index 6e3ab0c38c4d..f82e82109728 100644
--- a/drivers/ide/pci/generic.c
+++ b/drivers/ide/pci/generic.c
@@ -41,14 +41,15 @@
 
 static int ide_generic_all;             /* Set to claim all devices */
 
+#ifndef MODULE
 static int __init ide_generic_all_on(char *unused)
 {
         ide_generic_all = 1;
         printk(KERN_INFO "IDE generic will claim all unknown PCI IDE storage controllers.\n");
         return 1;
 }
-
 __setup("all-generic-ide", ide_generic_all_on);
+#endif
 
 static void __devinit init_hwif_generic (ide_hwif_t *hwif)
 {
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
index 75a2253a3e68..8e9d87701ce2 100644
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -112,6 +112,7 @@ static const struct {
 
         { "SiS5596",    PCI_DEVICE_ID_SI_5596,  ATA_16   },
         { "SiS5571",    PCI_DEVICE_ID_SI_5571,  ATA_16   },
+        { "SiS5517",    PCI_DEVICE_ID_SI_5517,  ATA_16   },
         { "SiS551x",    PCI_DEVICE_ID_SI_5511,  ATA_16   },
 };
 
@@ -524,6 +525,7 @@ static void config_art_rwp_pio (ide_drive_t *drive, u8 pio)
                         case 3:         test1 = 0x30|0x03; break;
                         case 2:         test1 = 0x40|0x04; break;
                         case 1:         test1 = 0x60|0x07; break;
+                        case 0:         test1 = 0x00; break;
                         default:        break;
                 }
                 pci_write_config_byte(dev, drive_pci, test1);
diff --git a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c
index c85b87cb59d1..3e677c4f8c28 100644
--- a/drivers/ide/pci/via82cxxx.c
+++ b/drivers/ide/pci/via82cxxx.c
@@ -440,7 +440,7 @@ static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif)
 
 
 #if defined(CONFIG_PPC_CHRP) && defined(CONFIG_PPC32)
-        if(_machine == _MACH_chrp && _chrp_type == _CHRP_Pegasos) {
+        if(machine_is(chrp) && _chrp_type == _CHRP_Pegasos) {
                 hwif->irq = hwif->channel ? 15 : 14;
         }
 #endif
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 5013b1285e22..78e30f803671 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1677,7 +1677,7 @@ MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match);
 void __init
 pmac_ide_probe(void)
 {
-        if (_machine != _MACH_Pmac)
+        if (!machine_is(powermac))
                 return;
 
 #ifdef CONFIG_BLK_DEV_IDE_PMAC_ATA100FIRST