diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2009-03-31 14:15:31 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:31 -0400 |
commit | bac08cee93f9cb37b40ecfa8eaf1f6d8daf3909b (patch) | |
tree | e3a5a3dd993077d64e16699e866e37ad66d652c8 /drivers/ide/tx4939ide.c | |
parent | deae17fd5d147ae65e277905343b7ea578574d12 (diff) |
ide: call {in|out}put_data() methods from tf_{read|load}() methods (take 2)
Handle IDE_FTFLAG_{IN|OUT}_DATA flags in tf_{read|load}() methods by calling
{in|out}put_data() methods to transfer 2 bytes -- this will allow us to move
that handling out of those methods altogether...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/tx4939ide.c')
-rw-r--r-- | drivers/ide/tx4939ide.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/ide/tx4939ide.c b/drivers/ide/tx4939ide.c index f1e9da71110c..c350d0c7ba4a 100644 --- a/drivers/ide/tx4939ide.c +++ b/drivers/ide/tx4939ide.c | |||
@@ -458,10 +458,9 @@ static void tx4939ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) | |||
458 | HIHI = 0xFF; | 458 | HIHI = 0xFF; |
459 | 459 | ||
460 | if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) { | 460 | if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) { |
461 | u16 data = (tf->hob_data << 8) | tf->data; | 461 | u8 data[2] = { tf->data, tf->hob_data }; |
462 | 462 | ||
463 | /* no endian swap */ | 463 | hwif->tp_ops->output_data(drive, cmd, data, 2); |
464 | __raw_writew(data, (void __iomem *)io_ports->data_addr); | ||
465 | } | 464 | } |
466 | 465 | ||
467 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) | 466 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) |
@@ -500,12 +499,12 @@ static void tx4939ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd) | |||
500 | struct ide_taskfile *tf = &cmd->tf; | 499 | struct ide_taskfile *tf = &cmd->tf; |
501 | 500 | ||
502 | if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { | 501 | if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { |
503 | u16 data; | 502 | u8 data[2]; |
504 | 503 | ||
505 | /* no endian swap */ | 504 | hwif->tp_ops->input_data(drive, cmd, data, 2); |
506 | data = __raw_readw((void __iomem *)io_ports->data_addr); | 505 | |
507 | tf->data = data & 0xff; | 506 | tf->data = data[0]; |
508 | tf->hob_data = (data >> 8) & 0xff; | 507 | tf->hob_data = data[1]; |
509 | } | 508 | } |
510 | 509 | ||
511 | /* be sure we're looking at the low order bits */ | 510 | /* be sure we're looking at the low order bits */ |