diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2009-03-31 14:15:31 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:31 -0400 |
commit | 35218d1ca808ed19b8c6f079ce91872b3deb2219 (patch) | |
tree | 4cc1748e9046ef26701c88b3c6448734f1a7e874 /drivers/ide/tx4938ide.c | |
parent | bac08cee93f9cb37b40ecfa8eaf1f6d8daf3909b (diff) |
ide: move data register access out of tf_{read|load}() methods (take 2)
Move IDE_FTFLAG_{IN|OUT}_DATA flag handling out of tf_{read|load}() methods
into the only two functions where these flags actually need to be handled:
do_rw_taskfile() and ide_complete_cmd()...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/tx4938ide.c')
-rw-r--r-- | drivers/ide/tx4938ide.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c index c075464308a0..be391b615963 100644 --- a/drivers/ide/tx4938ide.c +++ b/drivers/ide/tx4938ide.c | |||
@@ -92,12 +92,6 @@ static void tx4938ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) | |||
92 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) | 92 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) |
93 | HIHI = 0xFF; | 93 | HIHI = 0xFF; |
94 | 94 | ||
95 | if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) { | ||
96 | u8 data[2] = { tf->data, tf->hob_data }; | ||
97 | |||
98 | hwif->tp_ops->output_data(drive, cmd, data, 2); | ||
99 | } | ||
100 | |||
101 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) | 95 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) |
102 | tx4938ide_outb(tf->hob_feature, io_ports->feature_addr); | 96 | tx4938ide_outb(tf->hob_feature, io_ports->feature_addr); |
103 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT) | 97 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT) |
@@ -131,15 +125,6 @@ static void tx4938ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd) | |||
131 | struct ide_io_ports *io_ports = &hwif->io_ports; | 125 | struct ide_io_ports *io_ports = &hwif->io_ports; |
132 | struct ide_taskfile *tf = &cmd->tf; | 126 | struct ide_taskfile *tf = &cmd->tf; |
133 | 127 | ||
134 | if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { | ||
135 | u8 data[2]; | ||
136 | |||
137 | hwif->tp_ops->input_data(drive, cmd, data, 2); | ||
138 | |||
139 | tf->data = data[0]; | ||
140 | tf->hob_data = data[1]; | ||
141 | } | ||
142 | |||
143 | /* be sure we're looking at the low order bits */ | 128 | /* be sure we're looking at the low order bits */ |
144 | tx4938ide_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr); | 129 | tx4938ide_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr); |
145 | 130 | ||