diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:19 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:19 -0400 |
commit | 35c9b4daf4c94b30e5cede597d98016ebf31b5ad (patch) | |
tree | 3248b5b3602218537ce0bce420fbde27a07b526b /drivers/ide/sl82c105.c | |
parent | e698ea83a8531a6740dc657329dcf0728392d6ac (diff) |
ide: add ->dma_clear method and remove ->dma_timeout one
All custom ->dma_timeout implementations call the generic one thus it is
possible to have only an optional method for resetting DMA engine instead:
* Add ->dma_clear method and convert hpt366, pdc202xx_old and sl82c105
host drivers to use it.
* Always use ide_dma_timeout() in ide_dma_timeout_retry() and remove
->dma_timeout method.
* Make ide_dma_timeout() static.
There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/sl82c105.c')
-rw-r--r-- | drivers/ide/sl82c105.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/ide/sl82c105.c b/drivers/ide/sl82c105.c index d25137b04e7a..d6f8977191c8 100644 --- a/drivers/ide/sl82c105.c +++ b/drivers/ide/sl82c105.c | |||
@@ -189,14 +189,13 @@ static void sl82c105_dma_start(ide_drive_t *drive) | |||
189 | ide_dma_start(drive); | 189 | ide_dma_start(drive); |
190 | } | 190 | } |
191 | 191 | ||
192 | static void sl82c105_dma_timeout(ide_drive_t *drive) | 192 | static void sl82c105_dma_clear(ide_drive_t *drive) |
193 | { | 193 | { |
194 | struct pci_dev *dev = to_pci_dev(drive->hwif->dev); | 194 | struct pci_dev *dev = to_pci_dev(drive->hwif->dev); |
195 | 195 | ||
196 | DBG(("sl82c105_dma_timeout(drive:%s)\n", drive->name)); | 196 | DBG(("sl82c105_dma_clear(drive:%s)\n", drive->name)); |
197 | 197 | ||
198 | sl82c105_reset_host(dev); | 198 | sl82c105_reset_host(dev); |
199 | ide_dma_timeout(drive); | ||
200 | } | 199 | } |
201 | 200 | ||
202 | static int sl82c105_dma_end(ide_drive_t *drive) | 201 | static int sl82c105_dma_end(ide_drive_t *drive) |
@@ -298,7 +297,7 @@ static const struct ide_dma_ops sl82c105_dma_ops = { | |||
298 | .dma_test_irq = ide_dma_test_irq, | 297 | .dma_test_irq = ide_dma_test_irq, |
299 | .dma_lost_irq = sl82c105_dma_lost_irq, | 298 | .dma_lost_irq = sl82c105_dma_lost_irq, |
300 | .dma_timer_expiry = ide_dma_sff_timer_expiry, | 299 | .dma_timer_expiry = ide_dma_sff_timer_expiry, |
301 | .dma_timeout = sl82c105_dma_timeout, | 300 | .dma_clear = sl82c105_dma_clear, |
302 | .dma_sff_read_status = ide_dma_sff_read_status, | 301 | .dma_sff_read_status = ide_dma_sff_read_status, |
303 | }; | 302 | }; |
304 | 303 | ||