aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ide/scc_pata.c
diff options
context:
space:
mode:
authorSergei Shtylyov <sshtylyov@ru.mvista.com>2009-03-31 14:15:31 -0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-03-31 14:15:31 -0400
commitbac08cee93f9cb37b40ecfa8eaf1f6d8daf3909b (patch)
treee3a5a3dd993077d64e16699e866e37ad66d652c8 /drivers/ide/scc_pata.c
parentdeae17fd5d147ae65e277905343b7ea578574d12 (diff)
ide: call {in|out}put_data() methods from tf_{read|load}() methods (take 2)
Handle IDE_FTFLAG_{IN|OUT}_DATA flags in tf_{read|load}() methods by calling {in|out}put_data() methods to transfer 2 bytes -- this will allow us to move that handling out of those methods altogether... Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/scc_pata.c')
-rw-r--r--drivers/ide/scc_pata.c16
1 files changed, 10 insertions, 6 deletions
diff --git a/drivers/ide/scc_pata.c b/drivers/ide/scc_pata.c
index ea0a9752c6f9..9c47cbf8c506 100644
--- a/drivers/ide/scc_pata.c
+++ b/drivers/ide/scc_pata.c
@@ -656,9 +656,11 @@ static void scc_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
656 if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) 656 if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
657 HIHI = 0xFF; 657 HIHI = 0xFF;
658 658
659 if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) 659 if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
660 out_be32((void *)io_ports->data_addr, 660 u8 data[2] = { tf->data, tf->hob_data };
661 (tf->hob_data << 8) | tf->data); 661
662 scc_output_data(drive, NULL, data, 2);
663 }
662 664
663 if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) 665 if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
664 scc_ide_outb(tf->hob_feature, io_ports->feature_addr); 666 scc_ide_outb(tf->hob_feature, io_ports->feature_addr);
@@ -693,10 +695,12 @@ static void scc_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
693 struct ide_taskfile *tf = &cmd->tf; 695 struct ide_taskfile *tf = &cmd->tf;
694 696
695 if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { 697 if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) {
696 u16 data = (u16)in_be32((void *)io_ports->data_addr); 698 u8 data[2];
699
700 scc_input_data(drive, cmd, data, 2);
697 701
698 tf->data = data & 0xff; 702 tf->data = data[0];
699 tf->hob_data = (data >> 8) & 0xff; 703 tf->hob_data = data[1];
700 } 704 }
701 705
702 /* be sure we're looking at the low order bits */ 706 /* be sure we're looking at the low order bits */