aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ide/scc_pata.c
diff options
context:
space:
mode:
authorSergei Shtylyov <sshtylyov@ru.mvista.com>2009-04-08 08:13:02 -0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-04-08 08:13:02 -0400
commit4109d19af73826aa6fee1a1b951670381be88f8b (patch)
tree345093962cee2b99228f39a467020d2b0dd5572d /drivers/ide/scc_pata.c
parent745483f10c6cefb303007c6873e2bfce54efa8ed (diff)
ide: move common code out of tf_load() method
Move device register masking (and setting drive->select) out of tf_load() method and into the only function that needs to use this code, do_rw_taskfile()... Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> [bart: fix whitespace error] Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/scc_pata.c')
-rw-r--r--drivers/ide/scc_pata.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/ide/scc_pata.c b/drivers/ide/scc_pata.c
index 1238d5561976..f5a6fa0a8bea 100644
--- a/drivers/ide/scc_pata.c
+++ b/drivers/ide/scc_pata.c
@@ -650,10 +650,6 @@ static void scc_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
650 struct ide_io_ports *io_ports = &drive->hwif->io_ports; 650 struct ide_io_ports *io_ports = &drive->hwif->io_ports;
651 struct ide_taskfile *tf = &cmd->hob; 651 struct ide_taskfile *tf = &cmd->hob;
652 u8 valid = cmd->valid.out.hob; 652 u8 valid = cmd->valid.out.hob;
653 u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
654
655 if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
656 HIHI = 0xFF;
657 653
658 if (valid & IDE_VALID_FEATURE) 654 if (valid & IDE_VALID_FEATURE)
659 scc_ide_outb(tf->feature, io_ports->feature_addr); 655 scc_ide_outb(tf->feature, io_ports->feature_addr);
@@ -679,10 +675,8 @@ static void scc_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
679 scc_ide_outb(tf->lbam, io_ports->lbam_addr); 675 scc_ide_outb(tf->lbam, io_ports->lbam_addr);
680 if (valid & IDE_VALID_LBAH) 676 if (valid & IDE_VALID_LBAH)
681 scc_ide_outb(tf->lbah, io_ports->lbah_addr); 677 scc_ide_outb(tf->lbah, io_ports->lbah_addr);
682
683 if (valid & IDE_VALID_DEVICE) 678 if (valid & IDE_VALID_DEVICE)
684 scc_ide_outb((tf->device & HIHI) | drive->select, 679 scc_ide_outb(tf->device, io_ports->device_addr);
685 io_ports->device_addr);
686} 680}
687 681
688static void scc_tf_read(ide_drive_t *drive, struct ide_cmd *cmd) 682static void scc_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)