aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ide/ppc
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2007-10-13 11:47:49 -0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2007-10-13 11:47:49 -0400
commitddf151026a293725507fedc39b18ae6edb86d775 (patch)
tree649de86d3de0bfc686ce92e94a2f46979fc2fbfc /drivers/ide/ppc
parent218ee5f364ed006403f1bbe3c1da5af51b1bdb2a (diff)
ide-pmac: use __ide_wait_stat()
* Use __ide_wait_stat() instead of wait_for_ready() in pmac_ide_do_setfeature(). While at it do following changes to match __ide_wait_stat() call in ide_config_drive_speed(): * Wait WAIT_CMD time (20 sec) instead of 2 sec for device to clear BUSY_STAT. * Check DRQ_STAT bit (shouldn't be set for good device status). Also remove no longer needed wait_for_ready() from ide-iops.c. Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ppc')
-rw-r--r--drivers/ide/ppc/pmac.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 512452b379bd..13e26642dad7 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -541,7 +541,8 @@ static int
541pmac_ide_do_setfeature(ide_drive_t *drive, u8 command) 541pmac_ide_do_setfeature(ide_drive_t *drive, u8 command)
542{ 542{
543 ide_hwif_t *hwif = HWIF(drive); 543 ide_hwif_t *hwif = HWIF(drive);
544 int result = 1; 544 int result;
545 u8 stat;
545 546
546 disable_irq_nosync(hwif->irq); 547 disable_irq_nosync(hwif->irq);
547 udelay(1); 548 udelay(1);
@@ -552,9 +553,9 @@ pmac_ide_do_setfeature(ide_drive_t *drive, u8 command)
552 hwif->OUTB(command, IDE_NSECTOR_REG); 553 hwif->OUTB(command, IDE_NSECTOR_REG);
553 hwif->OUTB(SETFEATURES_XFER, IDE_FEATURE_REG); 554 hwif->OUTB(SETFEATURES_XFER, IDE_FEATURE_REG);
554 hwif->OUTBSYNC(drive, WIN_SETFEATURES, IDE_COMMAND_REG); 555 hwif->OUTBSYNC(drive, WIN_SETFEATURES, IDE_COMMAND_REG);
555 udelay(1); 556 result = __ide_wait_stat(drive, drive->ready_stat,
556 /* Timeout bumped for some powerbooks */ 557 BUSY_STAT|DRQ_STAT|ERR_STAT,
557 result = wait_for_ready(drive, 2000); 558 WAIT_CMD, &stat);
558 hwif->OUTB(drive->ctl, IDE_CONTROL_REG); 559 hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
559 if (result) 560 if (result)
560 printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready " 561 printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "