diff options
author | Rafael J. Wysocki <rjw@sisk.pl> | 2008-02-23 13:13:25 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-23 13:40:04 -0500 |
commit | 3a2d5b700132f35401f1d9e22fe3c2cab02c2549 (patch) | |
tree | ad991428c41aee92a5f78b06bf73430af0e6f7ae /drivers/ide/ppc/pmac.c | |
parent | 39273b58a409cd6d65c9732bdca00bacd1626672 (diff) |
PM: Introduce PM_EVENT_HIBERNATE callback state
During the last step of hibernation in the "platform" mode (with the
help of ACPI) we use the suspend code, including the devices'
->suspend() methods, to prepare the system for entering the ACPI S4
system sleep state.
But at least for some devices the operations performed by the
->suspend() callback in that case must be different from its operations
during regular suspend.
For this reason, introduce the new PM event type PM_EVENT_HIBERNATE and
pass it to the device drivers' ->suspend() methods during the last phase
of hibernation, so that they can distinguish this case and handle it as
appropriate. Modify the drivers that handle PM_EVENT_SUSPEND in a
special way and need to handle PM_EVENT_HIBERNATE in the same way.
These changes are necessary to fix a hibernation regression related
to the i915 driver (ref. http://lkml.org/lkml/2008/2/22/488).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Tested-by: Jeff Chua <jeff.chua.linux@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/ide/ppc/pmac.c')
-rw-r--r-- | drivers/ide/ppc/pmac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c index 12ac3bfb4f9a..78c9eeb85634 100644 --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c | |||
@@ -1254,7 +1254,7 @@ pmac_ide_macio_suspend(struct macio_dev *mdev, pm_message_t mesg) | |||
1254 | int rc = 0; | 1254 | int rc = 0; |
1255 | 1255 | ||
1256 | if (mesg.event != mdev->ofdev.dev.power.power_state.event | 1256 | if (mesg.event != mdev->ofdev.dev.power.power_state.event |
1257 | && mesg.event == PM_EVENT_SUSPEND) { | 1257 | && (mesg.event & PM_EVENT_SLEEP)) { |
1258 | rc = pmac_ide_do_suspend(hwif); | 1258 | rc = pmac_ide_do_suspend(hwif); |
1259 | if (rc == 0) | 1259 | if (rc == 0) |
1260 | mdev->ofdev.dev.power.power_state = mesg; | 1260 | mdev->ofdev.dev.power.power_state = mesg; |
@@ -1364,7 +1364,7 @@ pmac_ide_pci_suspend(struct pci_dev *pdev, pm_message_t mesg) | |||
1364 | int rc = 0; | 1364 | int rc = 0; |
1365 | 1365 | ||
1366 | if (mesg.event != pdev->dev.power.power_state.event | 1366 | if (mesg.event != pdev->dev.power.power_state.event |
1367 | && mesg.event == PM_EVENT_SUSPEND) { | 1367 | && (mesg.event & PM_EVENT_SLEEP)) { |
1368 | rc = pmac_ide_do_suspend(hwif); | 1368 | rc = pmac_ide_do_suspend(hwif); |
1369 | if (rc == 0) | 1369 | if (rc == 0) |
1370 | pdev->dev.power.power_state = mesg; | 1370 | pdev->dev.power.power_state = mesg; |