aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ide/pci
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2007-10-11 17:54:00 -0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2007-10-11 17:54:00 -0400
commit55f17e8da1f02ce0a36303a3f266c45045004cf5 (patch)
tree15116d738353dc99e7bf6d9f32044eedefeb1ae6 /drivers/ide/pci
parent26bcb879c03254545a19c6700fe5bcef6f21e7b1 (diff)
amd74xx/via82cxxx: use ide_tune_dma()
* Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs: - DMA capability bit not being checked on the device - DMA blacklist not being checked - DMA mode being programmed even if drive->autodma == 0 (thus possibly destroying PIO timings) * Bump driver version. Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci')
-rw-r--r--drivers/ide/pci/amd74xx.c15
-rw-r--r--drivers/ide/pci/via82cxxx.c15
2 files changed, 8 insertions, 22 deletions
diff --git a/drivers/ide/pci/amd74xx.c b/drivers/ide/pci/amd74xx.c
index 1088ba86cd1d..513205e52ad2 100644
--- a/drivers/ide/pci/amd74xx.c
+++ b/drivers/ide/pci/amd74xx.c
@@ -1,5 +1,5 @@
1/* 1/*
2 * Version 2.21 2 * Version 2.22
3 * 3 *
4 * AMD 755/756/766/8111 and nVidia nForce/2/2s/3/3s/CK804/MCP04 4 * AMD 755/756/766/8111 and nVidia nForce/2/2s/3/3s/CK804/MCP04
5 * IDE driver for Linux. 5 * IDE driver for Linux.
@@ -276,18 +276,11 @@ static void amd_set_pio_mode(ide_drive_t *drive, const u8 pio)
276 276
277static int amd74xx_ide_dma_check(ide_drive_t *drive) 277static int amd74xx_ide_dma_check(ide_drive_t *drive)
278{ 278{
279 u8 speed = ide_max_dma_mode(drive); 279 if (ide_tune_dma(drive))
280
281 if (speed == 0) {
282 ide_set_max_pio(drive);
283 return -1;
284 }
285
286 amd_set_drive(drive, speed);
287
288 if (drive->autodma)
289 return 0; 280 return 0;
290 281
282 ide_set_max_pio(drive);
283
291 return -1; 284 return -1;
292} 285}
293 286
diff --git a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c
index 2fc4f8835f19..3611ca6b13b7 100644
--- a/drivers/ide/pci/via82cxxx.c
+++ b/drivers/ide/pci/via82cxxx.c
@@ -1,6 +1,6 @@
1/* 1/*
2 * 2 *
3 * Version 3.47 3 * Version 3.48
4 * 4 *
5 * VIA IDE driver for Linux. Supported southbridges: 5 * VIA IDE driver for Linux. Supported southbridges:
6 * 6 *
@@ -217,18 +217,11 @@ static void via_set_pio_mode(ide_drive_t *drive, const u8 pio)
217 217
218static int via82cxxx_ide_dma_check (ide_drive_t *drive) 218static int via82cxxx_ide_dma_check (ide_drive_t *drive)
219{ 219{
220 u8 speed = ide_max_dma_mode(drive); 220 if (ide_tune_dma(drive))
221
222 if (speed == 0) {
223 ide_set_max_pio(drive);
224 return -1;
225 }
226
227 via_set_drive(drive, speed);
228
229 if (drive->autodma)
230 return 0; 221 return 0;
231 222
223 ide_set_max_pio(drive);
224
232 return -1; 225 return -1;
233} 226}
234 227