diff options
author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2006-12-08 05:39:58 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-08 11:29:03 -0500 |
commit | b1489009963b8c5132f2ffe23483e811d9ae5607 (patch) | |
tree | 66f8ada358e6e42dc7a65e3f7ed662d5bfc0d32a /drivers/ide/pci | |
parent | 6b49a257850fb8ad91f4c76bb712e9213141a34a (diff) |
[PATCH] ide: more conversion to pci_get APIs
This completes IDE except for one use which requires a new core PCI function
and will be polished up at the end
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/ide/pci')
-rw-r--r-- | drivers/ide/pci/alim15x3.c | 16 | ||||
-rw-r--r-- | drivers/ide/pci/pdc202xx_new.c | 7 | ||||
-rw-r--r-- | drivers/ide/pci/sis5513.c | 3 |
3 files changed, 15 insertions, 11 deletions
diff --git a/drivers/ide/pci/alim15x3.c b/drivers/ide/pci/alim15x3.c index d419e4bb54f4..89109be5162c 100644 --- a/drivers/ide/pci/alim15x3.c +++ b/drivers/ide/pci/alim15x3.c | |||
@@ -586,11 +586,11 @@ static unsigned int __devinit init_chipset_ali15x3 (struct pci_dev *dev, const c | |||
586 | { | 586 | { |
587 | unsigned long flags; | 587 | unsigned long flags; |
588 | u8 tmpbyte; | 588 | u8 tmpbyte; |
589 | struct pci_dev *north = pci_find_slot(0, PCI_DEVFN(0,0)); | 589 | struct pci_dev *north = pci_get_slot(dev->bus, PCI_DEVFN(0,0)); |
590 | 590 | ||
591 | pci_read_config_byte(dev, PCI_REVISION_ID, &m5229_revision); | 591 | pci_read_config_byte(dev, PCI_REVISION_ID, &m5229_revision); |
592 | 592 | ||
593 | isa_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, NULL); | 593 | isa_dev = pci_get_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, NULL); |
594 | 594 | ||
595 | #if defined(DISPLAY_ALI_TIMINGS) && defined(CONFIG_PROC_FS) | 595 | #if defined(DISPLAY_ALI_TIMINGS) && defined(CONFIG_PROC_FS) |
596 | if (!ali_proc) { | 596 | if (!ali_proc) { |
@@ -613,8 +613,7 @@ static unsigned int __devinit init_chipset_ali15x3 (struct pci_dev *dev, const c | |||
613 | * clear bit 7 | 613 | * clear bit 7 |
614 | */ | 614 | */ |
615 | pci_write_config_byte(dev, 0x4b, tmpbyte & 0x7F); | 615 | pci_write_config_byte(dev, 0x4b, tmpbyte & 0x7F); |
616 | local_irq_restore(flags); | 616 | goto out; |
617 | return 0; | ||
618 | } | 617 | } |
619 | 618 | ||
620 | /* | 619 | /* |
@@ -637,10 +636,8 @@ static unsigned int __devinit init_chipset_ali15x3 (struct pci_dev *dev, const c | |||
637 | * box without a device at 0:0.0. The ALi bridge will be at | 636 | * box without a device at 0:0.0. The ALi bridge will be at |
638 | * 0:0.0 so if we didn't find one we know what is cooking. | 637 | * 0:0.0 so if we didn't find one we know what is cooking. |
639 | */ | 638 | */ |
640 | if (north && north->vendor != PCI_VENDOR_ID_AL) { | 639 | if (north && north->vendor != PCI_VENDOR_ID_AL) |
641 | local_irq_restore(flags); | 640 | goto out; |
642 | return 0; | ||
643 | } | ||
644 | 641 | ||
645 | if (m5229_revision < 0xC5 && isa_dev) | 642 | if (m5229_revision < 0xC5 && isa_dev) |
646 | { | 643 | { |
@@ -661,6 +658,9 @@ static unsigned int __devinit init_chipset_ali15x3 (struct pci_dev *dev, const c | |||
661 | pci_write_config_byte(isa_dev, 0x79, tmpbyte | 0x02); | 658 | pci_write_config_byte(isa_dev, 0x79, tmpbyte | 0x02); |
662 | } | 659 | } |
663 | } | 660 | } |
661 | out: | ||
662 | pci_dev_put(north); | ||
663 | pci_dev_put(isa_dev); | ||
664 | local_irq_restore(flags); | 664 | local_irq_restore(flags); |
665 | return 0; | 665 | return 0; |
666 | } | 666 | } |
diff --git a/drivers/ide/pci/pdc202xx_new.c b/drivers/ide/pci/pdc202xx_new.c index 6c097e80b4df..0592dc0f96c0 100644 --- a/drivers/ide/pci/pdc202xx_new.c +++ b/drivers/ide/pci/pdc202xx_new.c | |||
@@ -362,6 +362,7 @@ static int __devinit init_setup_pdc20270(struct pci_dev *dev, | |||
362 | ide_pci_device_t *d) | 362 | ide_pci_device_t *d) |
363 | { | 363 | { |
364 | struct pci_dev *findev = NULL; | 364 | struct pci_dev *findev = NULL; |
365 | int ret; | ||
365 | 366 | ||
366 | if ((dev->bus->self && | 367 | if ((dev->bus->self && |
367 | dev->bus->self->vendor == PCI_VENDOR_ID_DEC) && | 368 | dev->bus->self->vendor == PCI_VENDOR_ID_DEC) && |
@@ -369,14 +370,16 @@ static int __devinit init_setup_pdc20270(struct pci_dev *dev, | |||
369 | if (PCI_SLOT(dev->devfn) & 2) | 370 | if (PCI_SLOT(dev->devfn) & 2) |
370 | return -ENODEV; | 371 | return -ENODEV; |
371 | d->extra = 0; | 372 | d->extra = 0; |
372 | while ((findev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, findev)) != NULL) { | 373 | while ((findev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, findev)) != NULL) { |
373 | if ((findev->vendor == dev->vendor) && | 374 | if ((findev->vendor == dev->vendor) && |
374 | (findev->device == dev->device) && | 375 | (findev->device == dev->device) && |
375 | (PCI_SLOT(findev->devfn) & 2)) { | 376 | (PCI_SLOT(findev->devfn) & 2)) { |
376 | if (findev->irq != dev->irq) { | 377 | if (findev->irq != dev->irq) { |
377 | findev->irq = dev->irq; | 378 | findev->irq = dev->irq; |
378 | } | 379 | } |
379 | return ide_setup_pci_devices(dev, findev, d); | 380 | ret = ide_setup_pci_devices(dev, findev, d); |
381 | pci_dev_put(findev); | ||
382 | return ret; | ||
380 | } | 383 | } |
381 | } | 384 | } |
382 | } | 385 | } |
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c index 92edf76bd7ad..6b313139b5e4 100644 --- a/drivers/ide/pci/sis5513.c +++ b/drivers/ide/pci/sis5513.c | |||
@@ -800,9 +800,10 @@ static unsigned int __devinit init_chipset_sis5513 (struct pci_dev *dev, const c | |||
800 | 800 | ||
801 | if (trueid == 0x5517) { /* SiS 961/961B */ | 801 | if (trueid == 0x5517) { /* SiS 961/961B */ |
802 | 802 | ||
803 | lpc_bridge = pci_find_slot(0x00, 0x10); /* Bus 0, Dev 2, Fn 0 */ | 803 | lpc_bridge = pci_get_slot(dev->bus, 0x10); /* Bus 0, Dev 2, Fn 0 */ |
804 | pci_read_config_byte(lpc_bridge, PCI_REVISION_ID, &sbrev); | 804 | pci_read_config_byte(lpc_bridge, PCI_REVISION_ID, &sbrev); |
805 | pci_read_config_byte(dev, 0x49, &prefctl); | 805 | pci_read_config_byte(dev, 0x49, &prefctl); |
806 | pci_dev_put(lpc_bridge); | ||
806 | 807 | ||
807 | if (sbrev == 0x10 && (prefctl & 0x80)) { | 808 | if (sbrev == 0x10 && (prefctl & 0x80)) { |
808 | printk(KERN_INFO "SIS5513: SiS 961B MuTIOL IDE UDMA133 controller\n"); | 809 | printk(KERN_INFO "SIS5513: SiS 961B MuTIOL IDE UDMA133 controller\n"); |