diff options
author | Denis Cheng <crquan@gmail.com> | 2008-02-05 20:57:49 -0500 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-02-05 20:57:49 -0500 |
commit | 594765a7316562cb7442f760a9a2f6e02804b610 (patch) | |
tree | dc9b68df0c9d459f228d50895b280aa98f411312 /drivers/ide/pci | |
parent | b004223db7249d42db893df916457acecc22759c (diff) |
ide-pci-generic: kill the unused ifdef/endif/MODULE code
with module_param macro, the __setup code can be killed now:
const __setup("all-generic-ide", ide_generic_all_on);
and the module name "generic.ko" is not descriptive to its functionality,
can be changed in Makefile, the "ide-pci-generic.ko" is better.
the ide-pci-generic.all-generic-ide parameter also documented
in Documentation/kernel-parameters.txt
Signed-off-by: Denis Cheng <crquan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci')
-rw-r--r-- | drivers/ide/pci/Makefile | 3 | ||||
-rw-r--r-- | drivers/ide/pci/generic.c | 13 |
2 files changed, 2 insertions, 14 deletions
diff --git a/drivers/ide/pci/Makefile b/drivers/ide/pci/Makefile index 94803253e8af..02e6ee7d751d 100644 --- a/drivers/ide/pci/Makefile +++ b/drivers/ide/pci/Makefile | |||
@@ -34,7 +34,8 @@ obj-$(CONFIG_BLK_DEV_TRM290) += trm290.o | |||
34 | obj-$(CONFIG_BLK_DEV_VIA82CXXX) += via82cxxx.o | 34 | obj-$(CONFIG_BLK_DEV_VIA82CXXX) += via82cxxx.o |
35 | 35 | ||
36 | # Must appear at the end of the block | 36 | # Must appear at the end of the block |
37 | obj-$(CONFIG_BLK_DEV_GENERIC) += generic.o | 37 | obj-$(CONFIG_BLK_DEV_GENERIC) += ide-pci-generic.o |
38 | ide-pci-generic-y += generic.o | ||
38 | 39 | ||
39 | ifeq ($(CONFIG_BLK_DEV_CMD640), m) | 40 | ifeq ($(CONFIG_BLK_DEV_CMD640), m) |
40 | obj-m += cmd640.o | 41 | obj-m += cmd640.o |
diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c index 9262a9174b4e..7fd83a9d4dee 100644 --- a/drivers/ide/pci/generic.c +++ b/drivers/ide/pci/generic.c | |||
@@ -29,19 +29,6 @@ | |||
29 | 29 | ||
30 | static int ide_generic_all; /* Set to claim all devices */ | 30 | static int ide_generic_all; /* Set to claim all devices */ |
31 | 31 | ||
32 | /* | ||
33 | * the module_param_named() was added for the modular case | ||
34 | * the __setup() is left as compatibility for existing setups | ||
35 | */ | ||
36 | #ifndef MODULE | ||
37 | static int __init ide_generic_all_on(char *unused) | ||
38 | { | ||
39 | ide_generic_all = 1; | ||
40 | printk(KERN_INFO "IDE generic will claim all unknown PCI IDE storage controllers.\n"); | ||
41 | return 1; | ||
42 | } | ||
43 | const __setup("all-generic-ide", ide_generic_all_on); | ||
44 | #endif | ||
45 | module_param_named(all_generic_ide, ide_generic_all, bool, 0444); | 32 | module_param_named(all_generic_ide, ide_generic_all, bool, 0444); |
46 | MODULE_PARM_DESC(all_generic_ide, "IDE generic will claim all unknown PCI IDE storage controllers."); | 33 | MODULE_PARM_DESC(all_generic_ide, "IDE generic will claim all unknown PCI IDE storage controllers."); |
47 | 34 | ||