diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
commit | ac95beedf8bc97b24f9540d4da9952f07221c023 (patch) | |
tree | c29837142c8083b6fcaf1767abcb0a4533676cd1 /drivers/ide/pci/slc90e66.c | |
parent | 4a27214d7be31e122db4102166f49ec15958e8e9 (diff) |
ide: add struct ide_port_ops (take 2)
* Move hooks for port/host specific methods from ide_hwif_t to
'struct ide_port_ops'.
* Add 'const struct ide_port_ops *port_ops' to 'struct ide_port_info'
and ide_hwif_t.
* Update host drivers and core code accordingly.
While at it:
* Rename ata66_*() cable detect functions to *_cable_detect() to match
the standard naming. (Suggested by Sergei Shtylyov)
v2:
* Fix build for bast-ide. (Noticed by Andrew Morton)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/slc90e66.c')
-rw-r--r-- | drivers/ide/pci/slc90e66.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/ide/pci/slc90e66.c b/drivers/ide/pci/slc90e66.c index eab557c45d1b..dae6e2c94d86 100644 --- a/drivers/ide/pci/slc90e66.c +++ b/drivers/ide/pci/slc90e66.c | |||
@@ -125,18 +125,16 @@ static u8 __devinit slc90e66_cable_detect(ide_hwif_t *hwif) | |||
125 | return (reg47 & mask) ? ATA_CBL_PATA40 : ATA_CBL_PATA80; | 125 | return (reg47 & mask) ? ATA_CBL_PATA40 : ATA_CBL_PATA80; |
126 | } | 126 | } |
127 | 127 | ||
128 | static void __devinit init_hwif_slc90e66(ide_hwif_t *hwif) | 128 | static const struct ide_port_ops slc90e66_port_ops = { |
129 | { | 129 | .set_pio_mode = slc90e66_set_pio_mode, |
130 | hwif->set_pio_mode = &slc90e66_set_pio_mode; | 130 | .set_dma_mode = slc90e66_set_dma_mode, |
131 | hwif->set_dma_mode = &slc90e66_set_dma_mode; | 131 | .cable_detect = slc90e66_cable_detect, |
132 | 132 | }; | |
133 | hwif->cable_detect = slc90e66_cable_detect; | ||
134 | } | ||
135 | 133 | ||
136 | static const struct ide_port_info slc90e66_chipset __devinitdata = { | 134 | static const struct ide_port_info slc90e66_chipset __devinitdata = { |
137 | .name = "SLC90E66", | 135 | .name = "SLC90E66", |
138 | .init_hwif = init_hwif_slc90e66, | ||
139 | .enablebits = { {0x41, 0x80, 0x80}, {0x43, 0x80, 0x80} }, | 136 | .enablebits = { {0x41, 0x80, 0x80}, {0x43, 0x80, 0x80} }, |
137 | .port_ops = &slc90e66_port_ops, | ||
140 | .host_flags = IDE_HFLAG_LEGACY_IRQS, | 138 | .host_flags = IDE_HFLAG_LEGACY_IRQS, |
141 | .pio_mask = ATA_PIO4, | 139 | .pio_mask = ATA_PIO4, |
142 | .swdma_mask = ATA_SWDMA2_ONLY, | 140 | .swdma_mask = ATA_SWDMA2_ONLY, |