diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2007-07-09 17:17:54 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-07-09 17:17:54 -0400 |
commit | 841d2a9bf16471716ba3a5172d24aa40a2ea9398 (patch) | |
tree | f836d41ed70bf3efd6350c293c0c31a40ef4f900 /drivers/ide/pci/sl82c105.c | |
parent | b740d8846e2e184909e9f74d4ad9d67ae0e084ea (diff) |
ide: make void and rename ide_dma_lostirq() method
Since ide_dma_lostirq() method's result is discarded, make it return 'void'.
While at it, rename the method to dma_lost_irq(), drop the '__' prefix from the
default method's name, and do some cleanups in this method driver-wise:
- in aec62xx.c, rename the method in accordance with other drivers, and get rid
of unnecessary variables there;
- in pdc202xx_old.c, define/use 'hwif' variable;
- in sgiioc4.c, rearrange the code to call the resetproc() method directly.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/sl82c105.c')
-rw-r--r-- | drivers/ide/pci/sl82c105.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/ide/pci/sl82c105.c b/drivers/ide/pci/sl82c105.c index 7c383d9cc472..202ce4965b60 100644 --- a/drivers/ide/pci/sl82c105.c +++ b/drivers/ide/pci/sl82c105.c | |||
@@ -195,7 +195,7 @@ static inline void sl82c105_reset_host(struct pci_dev *dev) | |||
195 | * This function is called when the IDE timer expires, the drive | 195 | * This function is called when the IDE timer expires, the drive |
196 | * indicates that it is READY, and we were waiting for DMA to complete. | 196 | * indicates that it is READY, and we were waiting for DMA to complete. |
197 | */ | 197 | */ |
198 | static int sl82c105_ide_dma_lostirq(ide_drive_t *drive) | 198 | static void sl82c105_dma_lost_irq(ide_drive_t *drive) |
199 | { | 199 | { |
200 | ide_hwif_t *hwif = HWIF(drive); | 200 | ide_hwif_t *hwif = HWIF(drive); |
201 | struct pci_dev *dev = hwif->pci_dev; | 201 | struct pci_dev *dev = hwif->pci_dev; |
@@ -222,9 +222,6 @@ static int sl82c105_ide_dma_lostirq(ide_drive_t *drive) | |||
222 | } | 222 | } |
223 | 223 | ||
224 | sl82c105_reset_host(dev); | 224 | sl82c105_reset_host(dev); |
225 | |||
226 | /* __ide_dma_lostirq would return 1, so we do as well */ | ||
227 | return 1; | ||
228 | } | 225 | } |
229 | 226 | ||
230 | /* | 227 | /* |
@@ -441,7 +438,7 @@ static void __devinit init_hwif_sl82c105(ide_hwif_t *hwif) | |||
441 | hwif->ide_dma_check = &sl82c105_ide_dma_check; | 438 | hwif->ide_dma_check = &sl82c105_ide_dma_check; |
442 | hwif->ide_dma_on = &sl82c105_ide_dma_on; | 439 | hwif->ide_dma_on = &sl82c105_ide_dma_on; |
443 | hwif->dma_off_quietly = &sl82c105_dma_off_quietly; | 440 | hwif->dma_off_quietly = &sl82c105_dma_off_quietly; |
444 | hwif->ide_dma_lostirq = &sl82c105_ide_dma_lostirq; | 441 | hwif->dma_lost_irq = &sl82c105_dma_lost_irq; |
445 | hwif->dma_start = &sl82c105_dma_start; | 442 | hwif->dma_start = &sl82c105_dma_start; |
446 | hwif->ide_dma_timeout = &sl82c105_ide_dma_timeout; | 443 | hwif->ide_dma_timeout = &sl82c105_ide_dma_timeout; |
447 | 444 | ||