diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-05-05 16:03:51 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-05-05 16:03:51 -0400 |
commit | 8e60d3762f32c9573a449950717a3de12dfebbe3 (patch) | |
tree | 0b0dbaa29765a012986dcf0a5fad560d9f095188 /drivers/ide/pci/siimage.c | |
parent | 0e9b4e535fec7e2a189952670937adfbe2826b63 (diff) |
siimage: fix wrong ->swdma_mask
This driver doesn't support SWDMA so use the correct ->swdma_mask.
While at it:
* no need to call config_chipset_for_pio() in config_chipset_for_dma(),
if DMA is not available config_chipset_for_pio() will be called
by siimage_config_drive_for_dma() and if DMA is available
config_siimage_chipset_for_pio() will be called by siimage_tune_chipset()
* remove needless config_chipset_for_pio() wrapper
* bump driver version
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/siimage.c')
-rw-r--r-- | drivers/ide/pci/siimage.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/ide/pci/siimage.c b/drivers/ide/pci/siimage.c index 71eccdf5f817..c0188de3cc66 100644 --- a/drivers/ide/pci/siimage.c +++ b/drivers/ide/pci/siimage.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * linux/drivers/ide/pci/siimage.c Version 1.11 Jan 27, 2007 | 2 | * linux/drivers/ide/pci/siimage.c Version 1.12 Mar 10 2007 |
3 | * | 3 | * |
4 | * Copyright (C) 2001-2002 Andre Hedrick <andre@linux-ide.org> | 4 | * Copyright (C) 2001-2002 Andre Hedrick <andre@linux-ide.org> |
5 | * Copyright (C) 2003 Red Hat <alan@redhat.com> | 5 | * Copyright (C) 2003 Red Hat <alan@redhat.com> |
@@ -287,11 +287,6 @@ static void config_siimage_chipset_for_pio (ide_drive_t *drive, byte set_speed) | |||
287 | (void) ide_config_drive_speed(drive, speed); | 287 | (void) ide_config_drive_speed(drive, speed); |
288 | } | 288 | } |
289 | 289 | ||
290 | static void config_chipset_for_pio (ide_drive_t *drive, byte set_speed) | ||
291 | { | ||
292 | config_siimage_chipset_for_pio(drive, set_speed); | ||
293 | } | ||
294 | |||
295 | /** | 290 | /** |
296 | * siimage_tune_chipset - set controller timings | 291 | * siimage_tune_chipset - set controller timings |
297 | * @drive: Drive to set up | 292 | * @drive: Drive to set up |
@@ -396,8 +391,6 @@ static int config_chipset_for_dma (ide_drive_t *drive) | |||
396 | { | 391 | { |
397 | u8 speed = ide_dma_speed(drive, siimage_ratemask(drive)); | 392 | u8 speed = ide_dma_speed(drive, siimage_ratemask(drive)); |
398 | 393 | ||
399 | config_chipset_for_pio(drive, !speed); | ||
400 | |||
401 | if (!speed) | 394 | if (!speed) |
402 | return 0; | 395 | return 0; |
403 | 396 | ||
@@ -423,7 +416,7 @@ static int siimage_config_drive_for_dma (ide_drive_t *drive) | |||
423 | return 0; | 416 | return 0; |
424 | 417 | ||
425 | if (ide_use_fast_pio(drive)) | 418 | if (ide_use_fast_pio(drive)) |
426 | config_chipset_for_pio(drive, 1); | 419 | config_siimage_chipset_for_pio(drive, 1); |
427 | 420 | ||
428 | return -1; | 421 | return -1; |
429 | } | 422 | } |
@@ -1015,7 +1008,6 @@ static void __devinit init_hwif_siimage(ide_hwif_t *hwif) | |||
1015 | 1008 | ||
1016 | hwif->ultra_mask = 0x7f; | 1009 | hwif->ultra_mask = 0x7f; |
1017 | hwif->mwdma_mask = 0x07; | 1010 | hwif->mwdma_mask = 0x07; |
1018 | hwif->swdma_mask = 0x07; | ||
1019 | 1011 | ||
1020 | if (!is_sata(hwif)) | 1012 | if (!is_sata(hwif)) |
1021 | hwif->atapi_dma = 1; | 1013 | hwif->atapi_dma = 1; |