diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-16 16:29:58 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-16 16:29:58 -0400 |
commit | 9ff6f72f432364991d68e99cae72cb141c166e70 (patch) | |
tree | e37e5dc6d1b2387f7cbc2909d5cb534d4a395a79 /drivers/ide/pci/sgiioc4.c | |
parent | 1b5169405e50b98b2bd1e4f86c7706ea24a59193 (diff) |
ide: remove hwif->autodma and drive->autodma
* hpt34x.c: disable DMA masks for HPT345
(hwif->autodma is zero so DMA won't be enabled anyway).
* trm290.c: disable IDE_HFLAG_TRUST_BIOS_FOR_DMA flag
(hwif->autodma is zero so DMA won't be enabled anyway).
* Check noautodma global variable instead of drive->autodma in ide_tune_dma().
This fixes handling of "ide=nodma" kernel parameter for icside, ide-cris,
au1xxx-ide, pmac, it821x, jmicron, sgiioc4 and siimage host drivers.
* Remove hwif->autodma (it was not checked by IDE core code anyway) and
drive->autodma (was set by all host drivers - except HPT345/TRM290 special
cases - unless "ide=nodma" was used).
While at it:
- remove needless printk() from icside.c
- remove stale FIXME/comment from ide-probe.c
- don't force DMA off if PCI bus-mastering had to be enabled in setup-pci.c
(this setting was always later over-ridden by host drivers anyway)
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/sgiioc4.c')
-rw-r--r-- | drivers/ide/pci/sgiioc4.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/ide/pci/sgiioc4.c b/drivers/ide/pci/sgiioc4.c index 210f32d1e93c..9a9474f534e5 100644 --- a/drivers/ide/pci/sgiioc4.c +++ b/drivers/ide/pci/sgiioc4.c | |||
@@ -674,12 +674,7 @@ sgiioc4_ide_setup_pci_device(struct pci_dev *dev) | |||
674 | /* Initializing chipset IRQ Registers */ | 674 | /* Initializing chipset IRQ Registers */ |
675 | writel(0x03, (void __iomem *)(irqport + IOC4_INTR_SET * 4)); | 675 | writel(0x03, (void __iomem *)(irqport + IOC4_INTR_SET * 4)); |
676 | 676 | ||
677 | hwif->autodma = 0; | 677 | if (dma_base == 0 || ide_dma_sgiioc4(hwif, dma_base)) |
678 | |||
679 | if (dma_base && ide_dma_sgiioc4(hwif, dma_base) == 0) { | ||
680 | hwif->autodma = 1; | ||
681 | hwif->drives[1].autodma = hwif->drives[0].autodma = 1; | ||
682 | } else | ||
683 | printk(KERN_INFO "%s: %s Bus-Master DMA disabled\n", | 678 | printk(KERN_INFO "%s: %s Bus-Master DMA disabled\n", |
684 | hwif->name, DRV_NAME); | 679 | hwif->name, DRV_NAME); |
685 | 680 | ||