diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-16 16:29:55 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-16 16:29:55 -0400 |
commit | 0ae2e178652753ae1797d407755a3505f7c1d2a7 (patch) | |
tree | fa725edcfb4b9752ebf2aa49a3e42e158537d4ed /drivers/ide/pci/sc1200.c | |
parent | b8b739d3361c16773a30fe5c0360336bbc19f435 (diff) |
ide: remove ->ide_dma_check (take 2)
* Add IDE_HFLAG_TRUST_BIOS_FOR_DMA host flag for host drivers that depend
on BIOS for programming device/controller for DMA. Set it in cy82c693,
generic, ns87415, opti621 and trm290 host drivers.
* Add IDE_HFLAG_VDMA host flag for host drivers using VDMA. Set it in cs5520
host driver.
* Teach ide_tune_dma() about IDE_HFLAG_TRUST_BIOS_FOR_DMA flag.
* Add generic ide_dma_check() helper and remove all open coded ->ide_dma_check
implementations. Fix all places checking for presence of ->ide_dma_check
hook to check for ->ide_dma_on instead.
* Remove no longer needed code from config_drive_for_dma().
* Make ide_tune_dma() static.
v2:
* Fix config_drive_for_dma() return values.
* Fix ide-dma.c build for CONFIG_BLK_DEV_IDEDMA_PCI=n by adding
dummy config_drive_for_dma() inline.
* Fix IDE_HFLAG_TRUST_BIOS_FOR_DMA handling in ide_dma_check().
* Fix init_hwif_it8213() comment.
There should be no functionality changes caused by this patch.
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/sc1200.c')
-rw-r--r-- | drivers/ide/pci/sc1200.c | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/drivers/ide/pci/sc1200.c b/drivers/ide/pci/sc1200.c index 184249ed125b..38cfc8c2ea58 100644 --- a/drivers/ide/pci/sc1200.c +++ b/drivers/ide/pci/sc1200.c | |||
@@ -199,21 +199,6 @@ static void sc1200_set_dma_mode(ide_drive_t *drive, const u8 mode) | |||
199 | } | 199 | } |
200 | } | 200 | } |
201 | 201 | ||
202 | /* | ||
203 | * sc1200_config_dma() handles selection/setting of DMA/UDMA modes | ||
204 | * for both the chipset and drive. | ||
205 | */ | ||
206 | static int sc1200_config_dma (ide_drive_t *drive) | ||
207 | { | ||
208 | if (ide_tune_dma(drive)) | ||
209 | return 0; | ||
210 | |||
211 | ide_set_max_pio(drive); | ||
212 | |||
213 | return -1; | ||
214 | } | ||
215 | |||
216 | |||
217 | /* Replacement for the standard ide_dma_end action in | 202 | /* Replacement for the standard ide_dma_end action in |
218 | * dma_proc. | 203 | * dma_proc. |
219 | * | 204 | * |
@@ -391,7 +376,6 @@ static void __devinit init_hwif_sc1200 (ide_hwif_t *hwif) | |||
391 | return; | 376 | return; |
392 | 377 | ||
393 | hwif->udma_filter = sc1200_udma_filter; | 378 | hwif->udma_filter = sc1200_udma_filter; |
394 | hwif->ide_dma_check = &sc1200_config_dma; | ||
395 | hwif->ide_dma_end = &sc1200_ide_dma_end; | 379 | hwif->ide_dma_end = &sc1200_ide_dma_end; |
396 | 380 | ||
397 | if (!noautodma) | 381 | if (!noautodma) |