diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2006-06-26 03:26:16 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-26 12:58:28 -0400 |
commit | 8b6ebe016bf68fc9b3f3f2ce79c1918b0808481c (patch) | |
tree | 695ae9c7a2e0053adb410b7e2e9b0797068fbf55 /drivers/ide/pci/pdc202xx_old.c | |
parent | 17c1033d331a430ce631805e15215e63b4cce764 (diff) |
[PATCH] ide: pdc202xx_old: remove the obsolete busproc
Remove the busproc from pdc202xx_old.c because:
- it handles the obsolete HDIO_TRISTATE_HWIF ioctl instead of the modern
HDIO_SET_BUSSTATE, so treats its argument wrong;
- I don't think that tristating both channels is good idea (probably can't
be done otherwise since there seems to be only single bit controlling this).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/ide/pci/pdc202xx_old.c')
-rw-r--r-- | drivers/ide/pci/pdc202xx_old.c | 29 |
1 files changed, 1 insertions, 28 deletions
diff --git a/drivers/ide/pci/pdc202xx_old.c b/drivers/ide/pci/pdc202xx_old.c index c6e87c5f1dc4..4cb15644941f 100644 --- a/drivers/ide/pci/pdc202xx_old.c +++ b/drivers/ide/pci/pdc202xx_old.c | |||
@@ -549,31 +549,6 @@ static void pdc202xx_reset (ide_drive_t *drive) | |||
549 | #endif | 549 | #endif |
550 | } | 550 | } |
551 | 551 | ||
552 | /* | ||
553 | * Since SUN Cobalt is attempting to do this operation, I should disclose | ||
554 | * this has been a long time ago Thu Jul 27 16:40:57 2000 was the patch date | ||
555 | * HOTSWAP ATA Infrastructure. | ||
556 | */ | ||
557 | static int pdc202xx_tristate (ide_drive_t * drive, int state) | ||
558 | { | ||
559 | ide_hwif_t *hwif = HWIF(drive); | ||
560 | // unsigned long high_16 = hwif->dma_base - (8*(hwif->channel)); | ||
561 | unsigned long high_16 = hwif->dma_master; | ||
562 | u8 sc1f = hwif->INB(high_16|0x001f); | ||
563 | |||
564 | if (!hwif) | ||
565 | return -EINVAL; | ||
566 | |||
567 | // hwif->bus_state = state; | ||
568 | |||
569 | if (state) { | ||
570 | hwif->OUTB(sc1f | 0x08, (high_16|0x001f)); | ||
571 | } else { | ||
572 | hwif->OUTB(sc1f & ~0x08, (high_16|0x001f)); | ||
573 | } | ||
574 | return 0; | ||
575 | } | ||
576 | |||
577 | static unsigned int __devinit init_chipset_pdc202xx(struct pci_dev *dev, const char *name) | 552 | static unsigned int __devinit init_chipset_pdc202xx(struct pci_dev *dev, const char *name) |
578 | { | 553 | { |
579 | if (dev->resource[PCI_ROM_RESOURCE].start) { | 554 | if (dev->resource[PCI_ROM_RESOURCE].start) { |
@@ -623,10 +598,8 @@ static void __devinit init_hwif_pdc202xx(ide_hwif_t *hwif) | |||
623 | hwif->tuneproc = &config_chipset_for_pio; | 598 | hwif->tuneproc = &config_chipset_for_pio; |
624 | hwif->quirkproc = &pdc202xx_quirkproc; | 599 | hwif->quirkproc = &pdc202xx_quirkproc; |
625 | 600 | ||
626 | if (hwif->pci_dev->device != PCI_DEVICE_ID_PROMISE_20246) { | 601 | if (hwif->pci_dev->device != PCI_DEVICE_ID_PROMISE_20246) |
627 | hwif->busproc = &pdc202xx_tristate; | ||
628 | hwif->resetproc = &pdc202xx_reset; | 602 | hwif->resetproc = &pdc202xx_reset; |
629 | } | ||
630 | 603 | ||
631 | hwif->speedproc = &pdc202xx_tune_chipset; | 604 | hwif->speedproc = &pdc202xx_tune_chipset; |
632 | 605 | ||