diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-18 18:30:07 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-18 18:30:07 -0400 |
commit | 5f8b6c34854a966fe5eb7241fde0419d47d5d408 (patch) | |
tree | 052afd508d9cd314f503d938182db55355f1b392 /drivers/ide/pci/opti621.c | |
parent | 9adf768a398745c539623210502b521e671c59d7 (diff) |
ide: add ->mwdma_mask and ->swdma_mask to ide_pci_device_t (take 2)
* Add ->mwdma_mask and ->swdma_mask to ide_pci_device_t.
* Set ide_hwif_t DMA masks using DMA masks from ide_pci_device_t in
setup-pci.c::ide_pci_setup_ports() (iff DMA base is valid and ->init_hwif
method may still override them).
* Convert IDE PCI host drivers to use ide_pci_device_t DMA masks.
While at it:
* Use ATA_{UDMA,MWDMA,SWDMA}* defines.
* hpt34x.c: add separate ide_pci_device_t instances for HPT343 and HPT345.
* serverworks.c: fix DMA masks being set before checking DMA base.
v2:
* Add missing masks to DECLARE_GENERIC_PCI_DEV() macro.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/opti621.c')
-rw-r--r-- | drivers/ide/pci/opti621.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/ide/pci/opti621.c b/drivers/ide/pci/opti621.c index 558cab537db8..24059c1b21df 100644 --- a/drivers/ide/pci/opti621.c +++ b/drivers/ide/pci/opti621.c | |||
@@ -332,12 +332,6 @@ static void __devinit init_hwif_opti621 (ide_hwif_t *hwif) | |||
332 | hwif->drives[1].drive_data = PIO_DONT_KNOW; | 332 | hwif->drives[1].drive_data = PIO_DONT_KNOW; |
333 | 333 | ||
334 | hwif->set_pio_mode = &opti621_set_pio_mode; | 334 | hwif->set_pio_mode = &opti621_set_pio_mode; |
335 | |||
336 | if (!(hwif->dma_base)) | ||
337 | return; | ||
338 | |||
339 | hwif->mwdma_mask = 0x07; | ||
340 | hwif->swdma_mask = 0x07; | ||
341 | } | 335 | } |
342 | 336 | ||
343 | static ide_pci_device_t opti621_chipsets[] __devinitdata = { | 337 | static ide_pci_device_t opti621_chipsets[] __devinitdata = { |
@@ -348,6 +342,8 @@ static ide_pci_device_t opti621_chipsets[] __devinitdata = { | |||
348 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA | | 342 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA | |
349 | IDE_HFLAG_BOOTABLE, | 343 | IDE_HFLAG_BOOTABLE, |
350 | .pio_mask = ATA_PIO3, | 344 | .pio_mask = ATA_PIO3, |
345 | .swdma_mask = ATA_SWDMA2, | ||
346 | .mwdma_mask = ATA_MWDMA2, | ||
351 | },{ /* 1 */ | 347 | },{ /* 1 */ |
352 | .name = "OPTI621X", | 348 | .name = "OPTI621X", |
353 | .init_hwif = init_hwif_opti621, | 349 | .init_hwif = init_hwif_opti621, |
@@ -355,6 +351,8 @@ static ide_pci_device_t opti621_chipsets[] __devinitdata = { | |||
355 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA | | 351 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA | |
356 | IDE_HFLAG_BOOTABLE, | 352 | IDE_HFLAG_BOOTABLE, |
357 | .pio_mask = ATA_PIO3, | 353 | .pio_mask = ATA_PIO3, |
354 | .swdma_mask = ATA_SWDMA2, | ||
355 | .mwdma_mask = ATA_MWDMA2, | ||
358 | } | 356 | } |
359 | }; | 357 | }; |
360 | 358 | ||