diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
commit | ac95beedf8bc97b24f9540d4da9952f07221c023 (patch) | |
tree | c29837142c8083b6fcaf1767abcb0a4533676cd1 /drivers/ide/pci/opti621.c | |
parent | 4a27214d7be31e122db4102166f49ec15958e8e9 (diff) |
ide: add struct ide_port_ops (take 2)
* Move hooks for port/host specific methods from ide_hwif_t to
'struct ide_port_ops'.
* Add 'const struct ide_port_ops *port_ops' to 'struct ide_port_info'
and ide_hwif_t.
* Update host drivers and core code accordingly.
While at it:
* Rename ata66_*() cable detect functions to *_cable_detect() to match
the standard naming. (Suggested by Sergei Shtylyov)
v2:
* Fix build for bast-ide. (Noticed by Andrew Morton)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/opti621.c')
-rw-r--r-- | drivers/ide/pci/opti621.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/drivers/ide/pci/opti621.c b/drivers/ide/pci/opti621.c index 88a4dd94eeea..9edacba20ffb 100644 --- a/drivers/ide/pci/opti621.c +++ b/drivers/ide/pci/opti621.c | |||
@@ -326,28 +326,24 @@ static void __devinit opti621_port_init_devs(ide_hwif_t *hwif) | |||
326 | hwif->drives[1].drive_data = PIO_DONT_KNOW; | 326 | hwif->drives[1].drive_data = PIO_DONT_KNOW; |
327 | } | 327 | } |
328 | 328 | ||
329 | /* | 329 | static const struct ide_port_ops opti621_port_ops = { |
330 | * init_hwif_opti621() is called once for each hwif found at boot. | 330 | .port_init_devs = opti621_port_init_devs, |
331 | */ | 331 | .set_pio_mode = opti621_set_pio_mode, |
332 | static void __devinit init_hwif_opti621(ide_hwif_t *hwif) | 332 | }; |
333 | { | ||
334 | hwif->port_init_devs = opti621_port_init_devs; | ||
335 | hwif->set_pio_mode = &opti621_set_pio_mode; | ||
336 | } | ||
337 | 333 | ||
338 | static const struct ide_port_info opti621_chipsets[] __devinitdata = { | 334 | static const struct ide_port_info opti621_chipsets[] __devinitdata = { |
339 | { /* 0 */ | 335 | { /* 0 */ |
340 | .name = "OPTI621", | 336 | .name = "OPTI621", |
341 | .init_hwif = init_hwif_opti621, | ||
342 | .enablebits = { {0x45, 0x80, 0x00}, {0x40, 0x08, 0x00} }, | 337 | .enablebits = { {0x45, 0x80, 0x00}, {0x40, 0x08, 0x00} }, |
338 | .port_ops = &opti621_port_ops, | ||
343 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA, | 339 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA, |
344 | .pio_mask = ATA_PIO3, | 340 | .pio_mask = ATA_PIO3, |
345 | .swdma_mask = ATA_SWDMA2, | 341 | .swdma_mask = ATA_SWDMA2, |
346 | .mwdma_mask = ATA_MWDMA2, | 342 | .mwdma_mask = ATA_MWDMA2, |
347 | }, { /* 1 */ | 343 | }, { /* 1 */ |
348 | .name = "OPTI621X", | 344 | .name = "OPTI621X", |
349 | .init_hwif = init_hwif_opti621, | ||
350 | .enablebits = { {0x45, 0x80, 0x00}, {0x40, 0x08, 0x00} }, | 345 | .enablebits = { {0x45, 0x80, 0x00}, {0x40, 0x08, 0x00} }, |
346 | .port_ops = &opti621_port_ops, | ||
351 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA, | 347 | .host_flags = IDE_HFLAG_TRUST_BIOS_FOR_DMA, |
352 | .pio_mask = ATA_PIO3, | 348 | .pio_mask = ATA_PIO3, |
353 | .swdma_mask = ATA_SWDMA2, | 349 | .swdma_mask = ATA_SWDMA2, |