diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-05-15 18:51:44 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-05-15 18:51:44 -0400 |
commit | a01ba4011aa745be44d0290c5da5cb2dfb4e37ce (patch) | |
tree | 63f95042ce5efcfa430cf61c3bcb77f98e7df017 /drivers/ide/pci/cs5530.c | |
parent | bd203b57c7edd6bc457b769cd15fa7239cd2241e (diff) |
cs5530/sc1200: DMA support cleanup
sc1200.c:
* remove open-coded variant of ide_dma_host_off() (== ->dma_host_off),
it is not needed because ->dma_off_quietly calls ->dma_host_off
* use ->dma_host_on (== ide_dma_host_on() for this driver) instead of
open-coded variant, call it from the users of sc1200_config_dma2()
[ there is no need to call ->dma_host_on in sc1200_config_dma() because
core code takes care of calling ->ide_dma_on on successful execution
of ->ide_dma_check ]
* add comment about ->tuneproc interface abuse
cs5530.c/sc1200.c:
* core code takes care of calling ->dma_off_quietly before calling
->ide_dma_check so there is no need to call it in ->ide_dma_check methods
* bump driver version
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/cs5530.c')
-rw-r--r-- | drivers/ide/pci/cs5530.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/ide/pci/cs5530.c b/drivers/ide/pci/cs5530.c index 845500115f3c..ec52dbec675f 100644 --- a/drivers/ide/pci/cs5530.c +++ b/drivers/ide/pci/cs5530.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * linux/drivers/ide/pci/cs5530.c Version 0.71 Mar 10 2007 | 2 | * linux/drivers/ide/pci/cs5530.c Version 0.72 Mar 10 2007 |
3 | * | 3 | * |
4 | * Copyright (C) 2000 Andre Hedrick <andre@linux-ide.org> | 4 | * Copyright (C) 2000 Andre Hedrick <andre@linux-ide.org> |
5 | * Copyright (C) 2000 Mark Lord <mlord@pobox.com> | 5 | * Copyright (C) 2000 Mark Lord <mlord@pobox.com> |
@@ -141,11 +141,6 @@ static int cs5530_config_dma(ide_drive_t *drive) | |||
141 | unsigned long basereg; | 141 | unsigned long basereg; |
142 | u8 unit = drive->dn & 1, mode = 0; | 142 | u8 unit = drive->dn & 1, mode = 0; |
143 | 143 | ||
144 | /* | ||
145 | * Default to DMA-off in case we run into trouble here. | ||
146 | */ | ||
147 | hwif->dma_off_quietly(drive); | ||
148 | |||
149 | if (ide_use_dma(drive)) | 144 | if (ide_use_dma(drive)) |
150 | mode = ide_max_dma_mode(drive); | 145 | mode = ide_max_dma_mode(drive); |
151 | 146 | ||