diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:24 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:24 -0400 |
commit | 5e37bdc081a980dd0d669e6387bcf15ca9666f81 (patch) | |
tree | d842166c3bd23fbf3dfba0ccaa0f9ed5cc3096db /drivers/ide/pci/cs5520.c | |
parent | 1fd1890594bd355a4217f5658a34763e77decee3 (diff) |
ide: add struct ide_dma_ops (take 3)
Add struct ide_dma_ops and convert core code + drivers to use it.
While at it:
* Drop "ide_" prefix from ->ide_dma_end and ->ide_dma_test_irq methods.
* Drop "ide_" "infixes" from DMA methods.
* au1xxx-ide.c:
- use auide_dma_{test_irq,end}() directly in auide_dma_timeout()
* pdc202xx_old.c:
- drop "old_" "infixes" from DMA methods
* siimage.c:
- add siimage_dma_test_irq() helper
- print SATA warning in siimage_init_one()
* Remove no longer needed ->init_hwif implementations.
v2:
* Changes based on review from Sergei:
- s/siimage_ide_dma_test_irq/siimage_dma_test_irq/
- s/drive->hwif/hwif/ in idefloppy_pc_intr().
- fix patch description w.r.t. au1xxx-ide changes
- fix au1xxx-ide build
- fix naming for cmd64*_dma_ops
- drop "ide_" and "old_" infixes
- s/hpt3xxx_dma_ops/hpt37x_dma_ops/
- s/hpt370x_dma_ops/hpt370_dma_ops/
- use correct DMA ops for HPT302/N, HPT371/N and HPT374
- s/it821x_smart_dma_ops/it821x_pass_through_dma_ops/
v3:
* Two bugs slipped in v2 (noticed by Sergei):
- use correct DMA ops for HPT374 (for real this time)
- handle HPT370/HPT370A properly
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/cs5520.c')
-rw-r--r-- | drivers/ide/pci/cs5520.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c index 41559c6de0ca..467d331c8109 100644 --- a/drivers/ide/pci/cs5520.c +++ b/drivers/ide/pci/cs5520.c | |||
@@ -103,24 +103,20 @@ static void cs5520_dma_host_set(ide_drive_t *drive, int on) | |||
103 | ide_dma_host_set(drive, on); | 103 | ide_dma_host_set(drive, on); |
104 | } | 104 | } |
105 | 105 | ||
106 | static void __devinit init_hwif_cs5520(ide_hwif_t *hwif) | ||
107 | { | ||
108 | if (hwif->dma_base == 0) | ||
109 | return; | ||
110 | |||
111 | hwif->dma_host_set = &cs5520_dma_host_set; | ||
112 | } | ||
113 | |||
114 | static const struct ide_port_ops cs5520_port_ops = { | 106 | static const struct ide_port_ops cs5520_port_ops = { |
115 | .set_pio_mode = cs5520_set_pio_mode, | 107 | .set_pio_mode = cs5520_set_pio_mode, |
116 | .set_dma_mode = cs5520_set_dma_mode, | 108 | .set_dma_mode = cs5520_set_dma_mode, |
117 | }; | 109 | }; |
118 | 110 | ||
111 | static struct ide_dma_ops cs5520_dma_ops = { | ||
112 | .dma_host_set = cs5520_dma_host_set, | ||
113 | }; | ||
114 | |||
119 | #define DECLARE_CS_DEV(name_str) \ | 115 | #define DECLARE_CS_DEV(name_str) \ |
120 | { \ | 116 | { \ |
121 | .name = name_str, \ | 117 | .name = name_str, \ |
122 | .init_hwif = init_hwif_cs5520, \ | ||
123 | .port_ops = &cs5520_port_ops, \ | 118 | .port_ops = &cs5520_port_ops, \ |
119 | .dma_ops = &cs5520_dma_ops, \ | ||
124 | .host_flags = IDE_HFLAG_ISA_PORTS | \ | 120 | .host_flags = IDE_HFLAG_ISA_PORTS | \ |
125 | IDE_HFLAG_CS5520 | \ | 121 | IDE_HFLAG_CS5520 | \ |
126 | IDE_HFLAG_VDMA | \ | 122 | IDE_HFLAG_VDMA | \ |