diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-16 16:29:58 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-16 16:29:58 -0400 |
commit | 9ff6f72f432364991d68e99cae72cb141c166e70 (patch) | |
tree | e37e5dc6d1b2387f7cbc2909d5cb534d4a395a79 /drivers/ide/pci/atiixp.c | |
parent | 1b5169405e50b98b2bd1e4f86c7706ea24a59193 (diff) |
ide: remove hwif->autodma and drive->autodma
* hpt34x.c: disable DMA masks for HPT345
(hwif->autodma is zero so DMA won't be enabled anyway).
* trm290.c: disable IDE_HFLAG_TRUST_BIOS_FOR_DMA flag
(hwif->autodma is zero so DMA won't be enabled anyway).
* Check noautodma global variable instead of drive->autodma in ide_tune_dma().
This fixes handling of "ide=nodma" kernel parameter for icside, ide-cris,
au1xxx-ide, pmac, it821x, jmicron, sgiioc4 and siimage host drivers.
* Remove hwif->autodma (it was not checked by IDE core code anyway) and
drive->autodma (was set by all host drivers - except HPT345/TRM290 special
cases - unless "ide=nodma" was used).
While at it:
- remove needless printk() from icside.c
- remove stale FIXME/comment from ide-probe.c
- don't force DMA off if PCI bus-mastering had to be enabled in setup-pci.c
(this setting was always later over-ridden by host drivers anyway)
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/pci/atiixp.c')
-rw-r--r-- | drivers/ide/pci/atiixp.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/ide/pci/atiixp.c b/drivers/ide/pci/atiixp.c index 2466e0a04e44..446900da1329 100644 --- a/drivers/ide/pci/atiixp.c +++ b/drivers/ide/pci/atiixp.c | |||
@@ -175,7 +175,6 @@ static void __devinit init_hwif_atiixp(ide_hwif_t *hwif) | |||
175 | if (!hwif->irq) | 175 | if (!hwif->irq) |
176 | hwif->irq = ch ? 15 : 14; | 176 | hwif->irq = ch ? 15 : 14; |
177 | 177 | ||
178 | hwif->autodma = 0; | ||
179 | hwif->set_pio_mode = &atiixp_set_pio_mode; | 178 | hwif->set_pio_mode = &atiixp_set_pio_mode; |
180 | hwif->set_dma_mode = &atiixp_set_dma_mode; | 179 | hwif->set_dma_mode = &atiixp_set_dma_mode; |
181 | hwif->drives[0].autotune = 1; | 180 | hwif->drives[0].autotune = 1; |
@@ -197,12 +196,6 @@ static void __devinit init_hwif_atiixp(ide_hwif_t *hwif) | |||
197 | 196 | ||
198 | hwif->dma_host_on = &atiixp_dma_host_on; | 197 | hwif->dma_host_on = &atiixp_dma_host_on; |
199 | hwif->dma_host_off = &atiixp_dma_host_off; | 198 | hwif->dma_host_off = &atiixp_dma_host_off; |
200 | |||
201 | if (!noautodma) | ||
202 | hwif->autodma = 1; | ||
203 | |||
204 | hwif->drives[1].autodma = hwif->autodma; | ||
205 | hwif->drives[0].autodma = hwif->autodma; | ||
206 | } | 199 | } |
207 | 200 | ||
208 | 201 | ||