diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-26 14:13:01 -0500 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-26 14:13:01 -0500 |
commit | 4a546e046d562bcd389149591fa5a534c8f832ca (patch) | |
tree | ffc5c7bd088a0bf74744721b9cfcf18220a75fdf /drivers/ide/mips | |
parent | 378f577f7f75aa18a0eeafb044a491dcd5aeaa3d (diff) |
ide: remove ->ide_dma_on and ->dma_off_quietly methods from ide_hwif_t
* Make ide_dma_off_quietly() and __ide_dma_on() always available.
* Drop "__" prefix from __ide_dma_on().
* Check for presence of ->dma_host_on instead of ->ide_dma_on.
* Convert all users of ->ide_dma_on and ->dma_off_quietly methods
to use ide_dma_on() and ide_dma_off_quietly() instead.
* Remove no longer needed ->ide_dma_on and ->dma_off_quietly methods
from ide_hwif_t.
* Make ide_dma_on() void.
There should be no functionality changes caused by this patch.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/mips')
-rw-r--r-- | drivers/ide/mips/au1xxx-ide.c | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/drivers/ide/mips/au1xxx-ide.c b/drivers/ide/mips/au1xxx-ide.c index 4fc032838051..4dfdca4ccbde 100644 --- a/drivers/ide/mips/au1xxx-ide.c +++ b/drivers/ide/mips/au1xxx-ide.c | |||
@@ -399,24 +399,10 @@ static void auide_dma_host_on(ide_drive_t *drive) | |||
399 | { | 399 | { |
400 | } | 400 | } |
401 | 401 | ||
402 | static int auide_dma_on(ide_drive_t *drive) | ||
403 | { | ||
404 | drive->using_dma = 1; | ||
405 | ide_toggle_bounce(drive, 1); | ||
406 | |||
407 | return 0; | ||
408 | } | ||
409 | |||
410 | static void auide_dma_host_off(ide_drive_t *drive) | 402 | static void auide_dma_host_off(ide_drive_t *drive) |
411 | { | 403 | { |
412 | } | 404 | } |
413 | 405 | ||
414 | static void auide_dma_off_quietly(ide_drive_t *drive) | ||
415 | { | ||
416 | drive->using_dma = 0; | ||
417 | ide_toggle_bounce(drive, 0); | ||
418 | } | ||
419 | |||
420 | static void auide_dma_lost_irq(ide_drive_t *drive) | 406 | static void auide_dma_lost_irq(ide_drive_t *drive) |
421 | { | 407 | { |
422 | printk(KERN_ERR "%s: IRQ lost\n", drive->name); | 408 | printk(KERN_ERR "%s: IRQ lost\n", drive->name); |
@@ -684,7 +670,6 @@ static int au_ide_probe(struct device *dev) | |||
684 | hwif->set_dma_mode = &auide_set_dma_mode; | 670 | hwif->set_dma_mode = &auide_set_dma_mode; |
685 | 671 | ||
686 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA | 672 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA |
687 | hwif->dma_off_quietly = &auide_dma_off_quietly; | ||
688 | hwif->dma_timeout = &auide_dma_timeout; | 673 | hwif->dma_timeout = &auide_dma_timeout; |
689 | 674 | ||
690 | hwif->mdma_filter = &auide_mdma_filter; | 675 | hwif->mdma_filter = &auide_mdma_filter; |
@@ -697,7 +682,6 @@ static int au_ide_probe(struct device *dev) | |||
697 | hwif->dma_host_off = &auide_dma_host_off; | 682 | hwif->dma_host_off = &auide_dma_host_off; |
698 | hwif->dma_host_on = &auide_dma_host_on; | 683 | hwif->dma_host_on = &auide_dma_host_on; |
699 | hwif->dma_lost_irq = &auide_dma_lost_irq; | 684 | hwif->dma_lost_irq = &auide_dma_lost_irq; |
700 | hwif->ide_dma_on = &auide_dma_on; | ||
701 | #else /* !CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA */ | 685 | #else /* !CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA */ |
702 | hwif->channel = 0; | 686 | hwif->channel = 0; |
703 | hwif->hold = 1; | 687 | hwif->hold = 1; |