diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-19 18:32:31 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-10-19 18:32:31 -0400 |
commit | 8447d9d52adbe4c653482bd0d5ccb9b5d26f9c9d (patch) | |
tree | 358aa3ca6b0657623b84e7c6278f90fc95a32879 /drivers/ide/mips | |
parent | fd9bb53942a7ca3398a63f2c238afd8fbed3ec0e (diff) |
ide: add ide_device_add()
* Add ide_device_add() helper and convert host drivers to use it
instead of open-coded variants.
* Make ide_pci_setup_ports() and do_ide_setup_pci_device()
take 'u8 *idx' argument instead of 'ata_index_t *index'.
* Remove no longer needed ata_index_t.
* Unexport probe_hwif_init() and make it static.
* Unexport ide_proc_register_port().
There should be no functionality changes caused by this patch
(sgiioc4.c: ide_proc_register_port() requires hwif->present
to be set and it won't be set if probe_hwif_init() fails).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/mips')
-rw-r--r-- | drivers/ide/mips/au1xxx-ide.c | 5 | ||||
-rw-r--r-- | drivers/ide/mips/swarm.c | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/drivers/ide/mips/au1xxx-ide.c b/drivers/ide/mips/au1xxx-ide.c index 2f322d7e881b..be43024a359c 100644 --- a/drivers/ide/mips/au1xxx-ide.c +++ b/drivers/ide/mips/au1xxx-ide.c | |||
@@ -603,6 +603,7 @@ static int au_ide_probe(struct device *dev) | |||
603 | struct resource *res; | 603 | struct resource *res; |
604 | hw_regs_t *hw; | 604 | hw_regs_t *hw; |
605 | int ret = 0; | 605 | int ret = 0; |
606 | u8 idx[4] = { 0xff, 0xff, 0xff, 0xff }; | ||
606 | 607 | ||
607 | #if defined(CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA) | 608 | #if defined(CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA) |
608 | char *mode = "MWDMA2"; | 609 | char *mode = "MWDMA2"; |
@@ -717,9 +718,9 @@ static int au_ide_probe(struct device *dev) | |||
717 | dbdma_init_done = 1; | 718 | dbdma_init_done = 1; |
718 | #endif | 719 | #endif |
719 | 720 | ||
720 | probe_hwif_init(hwif); | 721 | idx[0] = hwif->index; |
721 | 722 | ||
722 | ide_proc_register_port(hwif); | 723 | ide_device_add(idx); |
723 | 724 | ||
724 | dev_set_drvdata(dev, hwif); | 725 | dev_set_drvdata(dev, hwif); |
725 | 726 | ||
diff --git a/drivers/ide/mips/swarm.c b/drivers/ide/mips/swarm.c index c2e29571b007..6ccc51d77e88 100644 --- a/drivers/ide/mips/swarm.c +++ b/drivers/ide/mips/swarm.c | |||
@@ -71,6 +71,7 @@ static int __devinit swarm_ide_probe(struct device *dev) | |||
71 | u8 __iomem *base; | 71 | u8 __iomem *base; |
72 | phys_t offset, size; | 72 | phys_t offset, size; |
73 | int i; | 73 | int i; |
74 | u8 idx[4] = { 0xff, 0xff, 0xff, 0xff }; | ||
74 | 75 | ||
75 | if (!SIBYTE_HAVE_IDE) | 76 | if (!SIBYTE_HAVE_IDE) |
76 | return -ENODEV; | 77 | return -ENODEV; |
@@ -128,9 +129,9 @@ static int __devinit swarm_ide_probe(struct device *dev) | |||
128 | memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports)); | 129 | memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports)); |
129 | hwif->irq = hwif->hw.irq; | 130 | hwif->irq = hwif->hw.irq; |
130 | 131 | ||
131 | probe_hwif_init(hwif); | 132 | idx[0] = hwif->index; |
132 | 133 | ||
133 | ide_proc_register_port(hwif); | 134 | ide_device_add(idx); |
134 | 135 | ||
135 | dev_set_drvdata(dev, hwif); | 136 | dev_set_drvdata(dev, hwif); |
136 | 137 | ||