diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
commit | ac95beedf8bc97b24f9540d4da9952f07221c023 (patch) | |
tree | c29837142c8083b6fcaf1767abcb0a4533676cd1 /drivers/ide/legacy/umc8672.c | |
parent | 4a27214d7be31e122db4102166f49ec15958e8e9 (diff) |
ide: add struct ide_port_ops (take 2)
* Move hooks for port/host specific methods from ide_hwif_t to
'struct ide_port_ops'.
* Add 'const struct ide_port_ops *port_ops' to 'struct ide_port_info'
and ide_hwif_t.
* Update host drivers and core code accordingly.
While at it:
* Rename ata66_*() cable detect functions to *_cable_detect() to match
the standard naming. (Suggested by Sergei Shtylyov)
v2:
* Fix build for bast-ide. (Noticed by Andrew Morton)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/legacy/umc8672.c')
-rw-r--r-- | drivers/ide/legacy/umc8672.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/ide/legacy/umc8672.c b/drivers/ide/legacy/umc8672.c index 4d90badd2bda..757156060a6b 100644 --- a/drivers/ide/legacy/umc8672.c +++ b/drivers/ide/legacy/umc8672.c | |||
@@ -120,8 +120,13 @@ static void umc_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
120 | spin_unlock_irqrestore(&ide_lock, flags); | 120 | spin_unlock_irqrestore(&ide_lock, flags); |
121 | } | 121 | } |
122 | 122 | ||
123 | static const struct ide_port_ops umc8672_port_ops = { | ||
124 | .set_pio_mode = umc_set_pio_mode, | ||
125 | }; | ||
126 | |||
123 | static const struct ide_port_info umc8672_port_info __initdata = { | 127 | static const struct ide_port_info umc8672_port_info __initdata = { |
124 | .chipset = ide_umc8672, | 128 | .chipset = ide_umc8672, |
129 | .port_ops = &umc8672_port_ops, | ||
125 | .host_flags = IDE_HFLAG_NO_DMA | IDE_HFLAG_NO_AUTOTUNE, | 130 | .host_flags = IDE_HFLAG_NO_DMA | IDE_HFLAG_NO_AUTOTUNE, |
126 | .pio_mask = ATA_PIO4, | 131 | .pio_mask = ATA_PIO4, |
127 | }; | 132 | }; |
@@ -161,14 +166,12 @@ static int __init umc8672_probe(void) | |||
161 | hwif = ide_find_port(); | 166 | hwif = ide_find_port(); |
162 | if (hwif) { | 167 | if (hwif) { |
163 | ide_init_port_hw(hwif, &hw[0]); | 168 | ide_init_port_hw(hwif, &hw[0]); |
164 | hwif->set_pio_mode = umc_set_pio_mode; | ||
165 | idx[0] = hwif->index; | 169 | idx[0] = hwif->index; |
166 | } | 170 | } |
167 | 171 | ||
168 | mate = ide_find_port(); | 172 | mate = ide_find_port(); |
169 | if (mate) { | 173 | if (mate) { |
170 | ide_init_port_hw(mate, &hw[1]); | 174 | ide_init_port_hw(mate, &hw[1]); |
171 | mate->set_pio_mode = umc_set_pio_mode; | ||
172 | idx[1] = mate->index; | 175 | idx[1] = mate->index; |
173 | } | 176 | } |
174 | 177 | ||