diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:47 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:47 -0400 |
commit | 35b5d0be3d8de9a5ac51471c12029fb115200cdc (patch) | |
tree | a9957b1952ad21c3313a39b3dc2ccdde3010035e /drivers/ide/ide-taskfile.c | |
parent | 22117d6eaac50d366d9013c88318a869ea4d8739 (diff) |
ide: remove ide_execute_pkt_cmd() (v2)
* Pass command structure to ide_execute_command() and skip
__ide_set_handler() for ATAPI protocols on non-DRQ devices.
* Convert ide_issue_pc() to always use ide_execute_command()
and remove no longer needed ide_execute_pkt_cmd().
v2:
* Fix for non-DRQ devices (based on report from Borislav).
There should be no functional changes caused by this patch.
Acked-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-taskfile.c')
-rw-r--r-- | drivers/ide/ide-taskfile.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c index f5cf04cf5712..329fd6f13f79 100644 --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide-taskfile.c | |||
@@ -97,8 +97,7 @@ ide_startstop_t do_rw_taskfile(ide_drive_t *drive, struct ide_cmd *orig_cmd) | |||
97 | case ATA_PROT_NODATA: | 97 | case ATA_PROT_NODATA: |
98 | if (handler == NULL) | 98 | if (handler == NULL) |
99 | handler = task_no_data_intr; | 99 | handler = task_no_data_intr; |
100 | ide_execute_command(drive, tf->command, handler, | 100 | ide_execute_command(drive, cmd, handler, WAIT_WORSTCASE); |
101 | WAIT_WORSTCASE); | ||
102 | return ide_started; | 101 | return ide_started; |
103 | case ATA_PROT_DMA: | 102 | case ATA_PROT_DMA: |
104 | if ((drive->dev_flags & IDE_DFLAG_USING_DMA) == 0 || | 103 | if ((drive->dev_flags & IDE_DFLAG_USING_DMA) == 0 || |
@@ -106,8 +105,7 @@ ide_startstop_t do_rw_taskfile(ide_drive_t *drive, struct ide_cmd *orig_cmd) | |||
106 | dma_ops->dma_setup(drive, cmd)) | 105 | dma_ops->dma_setup(drive, cmd)) |
107 | return ide_stopped; | 106 | return ide_stopped; |
108 | hwif->expiry = dma_ops->dma_timer_expiry; | 107 | hwif->expiry = dma_ops->dma_timer_expiry; |
109 | ide_execute_command(drive, tf->command, ide_dma_intr, | 108 | ide_execute_command(drive, cmd, ide_dma_intr, 2 * WAIT_CMD); |
110 | 2 * WAIT_CMD); | ||
111 | dma_ops->dma_start(drive); | 109 | dma_ops->dma_start(drive); |
112 | default: | 110 | default: |
113 | return ide_started; | 111 | return ide_started; |