diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:25 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:25 -0400 |
commit | 41fa9f863baacd32dd049daf8050d55a0c9e6f1a (patch) | |
tree | 44cc612753746cd459e122f102c72f33b36aa6b7 /drivers/ide/ide-tape.c | |
parent | b5479167f4206e0d821a51ae149d921cd7a58e54 (diff) |
ide: decrease size of ->pc_buf field in struct ide_atapi_pc
struct ide_atapi_pc is often allocated on the stack and size of ->pc_buf
size is 256 bytes. However since only ide_floppy_create_read_capacity_cmd()
and idetape_create_inquiry_cmd() require such size allocate buffers for
these pc-s explicitely and decrease ->pc_buf size to 64 bytes.
Cc: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-tape.c')
-rw-r--r-- | drivers/ide/ide-tape.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 64dfa7458f8d..cafc67d9e2e8 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c | |||
@@ -2014,9 +2014,13 @@ static void idetape_get_inquiry_results(ide_drive_t *drive) | |||
2014 | { | 2014 | { |
2015 | idetape_tape_t *tape = drive->driver_data; | 2015 | idetape_tape_t *tape = drive->driver_data; |
2016 | struct ide_atapi_pc pc; | 2016 | struct ide_atapi_pc pc; |
2017 | u8 pc_buf[256]; | ||
2017 | char fw_rev[4], vendor_id[8], product_id[16]; | 2018 | char fw_rev[4], vendor_id[8], product_id[16]; |
2018 | 2019 | ||
2019 | idetape_create_inquiry_cmd(&pc); | 2020 | idetape_create_inquiry_cmd(&pc); |
2021 | pc.buf = &pc_buf[0]; | ||
2022 | pc.buf_size = sizeof(pc_buf); | ||
2023 | |||
2020 | if (ide_queue_pc_tail(drive, tape->disk, &pc)) { | 2024 | if (ide_queue_pc_tail(drive, tape->disk, &pc)) { |
2021 | printk(KERN_ERR "ide-tape: %s: can't get INQUIRY results\n", | 2025 | printk(KERN_ERR "ide-tape: %s: can't get INQUIRY results\n", |
2022 | tape->name); | 2026 | tape->name); |