diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-25 16:17:19 -0500 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-25 16:17:19 -0500 |
commit | 7b905994ce0bd332afc5ebc30ce9afa60d23c6e2 (patch) | |
tree | 4f0f25616d816087e0022dce95f996c99c8dcc6e /drivers/ide/ide-probe.c | |
parent | 23b1bd459c9e8a925381960f0b69ac85468c3af1 (diff) |
ide: cleanup ide_set_dma()
* ->dma_off_quietly is always called before ide_set_dma()
so the call can be moved inside ide_set_dma().
* ide_dma_check() doesn't touch hardware so ->dma_off_quietly
call for 'rc == -1' case is redundant, remove it.
* '0' and '-1' are the only values returned by ide_dma_check()
so remove dead code for other cases.
There should be no functionality changes caused by this patch.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-probe.c')
-rw-r--r-- | drivers/ide/ide-probe.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index 33e62d28465d..0379d1f697cf 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c | |||
@@ -833,16 +833,8 @@ static void probe_hwif(ide_hwif_t *hwif) | |||
833 | 833 | ||
834 | drive->nice1 = 1; | 834 | drive->nice1 = 1; |
835 | 835 | ||
836 | if (hwif->ide_dma_on) { | 836 | if (hwif->ide_dma_on) |
837 | /* | ||
838 | * Force DMAing for the beginning of the check. | ||
839 | * Some chipsets appear to do interesting | ||
840 | * things, if not checked and cleared. | ||
841 | * PARANOIA!!! | ||
842 | */ | ||
843 | hwif->dma_off_quietly(drive); | ||
844 | ide_set_dma(drive); | 837 | ide_set_dma(drive); |
845 | } | ||
846 | } | 838 | } |
847 | } | 839 | } |
848 | 840 | ||