diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
commit | 22aa4b32a19b1f231d4ce7e9af6354b577a22a35 (patch) | |
tree | 3e773e7102e4ea6bb6b4c00edce442c4e8f37edb /drivers/ide/ide-lib.c | |
parent | e6830a86c260d73c6f370aa7ed17ee6c71e5ee05 (diff) |
ide: remove ide_task_t typedef
While at it:
- rename struct ide_task_s to struct ide_cmd
- remove stale comments from idedisk_{read_native,set}_max_address()
- drop unused 'cmd' argument from ide_{cmd,task}_ioctl()
- drop unused 'task' argument from tx4939ide_tf_load_fixup()
- rename ide_complete_task() to ide_complete_cmd()
- use consistent naming for struct ide_cmd variables
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-lib.c')
-rw-r--r-- | drivers/ide/ide-lib.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c index f6c683dd2987..217b7fdf2b17 100644 --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c | |||
@@ -34,19 +34,19 @@ void ide_toggle_bounce(ide_drive_t *drive, int on) | |||
34 | static void ide_dump_opcode(ide_drive_t *drive) | 34 | static void ide_dump_opcode(ide_drive_t *drive) |
35 | { | 35 | { |
36 | struct request *rq = drive->hwif->rq; | 36 | struct request *rq = drive->hwif->rq; |
37 | ide_task_t *task = NULL; | 37 | struct ide_cmd *cmd = NULL; |
38 | 38 | ||
39 | if (!rq) | 39 | if (!rq) |
40 | return; | 40 | return; |
41 | 41 | ||
42 | if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE) | 42 | if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE) |
43 | task = rq->special; | 43 | cmd = rq->special; |
44 | 44 | ||
45 | printk(KERN_ERR "ide: failed opcode was: "); | 45 | printk(KERN_ERR "ide: failed opcode was: "); |
46 | if (task == NULL) | 46 | if (cmd == NULL) |
47 | printk(KERN_CONT "unknown\n"); | 47 | printk(KERN_CONT "unknown\n"); |
48 | else | 48 | else |
49 | printk(KERN_CONT "0x%02x\n", task->tf.command); | 49 | printk(KERN_CONT "0x%02x\n", cmd->tf.command); |
50 | } | 50 | } |
51 | 51 | ||
52 | u64 ide_get_lba_addr(struct ide_taskfile *tf, int lba48) | 52 | u64 ide_get_lba_addr(struct ide_taskfile *tf, int lba48) |
@@ -66,18 +66,18 @@ EXPORT_SYMBOL_GPL(ide_get_lba_addr); | |||
66 | 66 | ||
67 | static void ide_dump_sector(ide_drive_t *drive) | 67 | static void ide_dump_sector(ide_drive_t *drive) |
68 | { | 68 | { |
69 | ide_task_t task; | 69 | struct ide_cmd cmd; |
70 | struct ide_taskfile *tf = &task.tf; | 70 | struct ide_taskfile *tf = &cmd.tf; |
71 | u8 lba48 = !!(drive->dev_flags & IDE_DFLAG_LBA48); | 71 | u8 lba48 = !!(drive->dev_flags & IDE_DFLAG_LBA48); |
72 | 72 | ||
73 | memset(&task, 0, sizeof(task)); | 73 | memset(&cmd, 0, sizeof(cmd)); |
74 | if (lba48) | 74 | if (lba48) |
75 | task.tf_flags = IDE_TFLAG_IN_LBA | IDE_TFLAG_IN_HOB_LBA | | 75 | cmd.tf_flags = IDE_TFLAG_IN_LBA | IDE_TFLAG_IN_HOB_LBA | |
76 | IDE_TFLAG_LBA48; | 76 | IDE_TFLAG_LBA48; |
77 | else | 77 | else |
78 | task.tf_flags = IDE_TFLAG_IN_LBA | IDE_TFLAG_IN_DEVICE; | 78 | cmd.tf_flags = IDE_TFLAG_IN_LBA | IDE_TFLAG_IN_DEVICE; |
79 | 79 | ||
80 | drive->hwif->tp_ops->tf_read(drive, &task); | 80 | drive->hwif->tp_ops->tf_read(drive, &cmd); |
81 | 81 | ||
82 | if (lba48 || (tf->device & ATA_LBA)) | 82 | if (lba48 || (tf->device & ATA_LBA)) |
83 | printk(KERN_CONT ", LBAsect=%llu", | 83 | printk(KERN_CONT ", LBAsect=%llu", |