diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
commit | 22aa4b32a19b1f231d4ce7e9af6354b577a22a35 (patch) | |
tree | 3e773e7102e4ea6bb6b4c00edce442c4e8f37edb /drivers/ide/ide-iops.c | |
parent | e6830a86c260d73c6f370aa7ed17ee6c71e5ee05 (diff) |
ide: remove ide_task_t typedef
While at it:
- rename struct ide_task_s to struct ide_cmd
- remove stale comments from idedisk_{read_native,set}_max_address()
- drop unused 'cmd' argument from ide_{cmd,task}_ioctl()
- drop unused 'task' argument from tx4939ide_tf_load_fixup()
- rename ide_complete_task() to ide_complete_cmd()
- use consistent naming for struct ide_cmd variables
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-iops.c')
-rw-r--r-- | drivers/ide/ide-iops.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c index 317c5dadd7c0..c3023de7270c 100644 --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c | |||
@@ -31,15 +31,15 @@ void SELECT_DRIVE(ide_drive_t *drive) | |||
31 | { | 31 | { |
32 | ide_hwif_t *hwif = drive->hwif; | 32 | ide_hwif_t *hwif = drive->hwif; |
33 | const struct ide_port_ops *port_ops = hwif->port_ops; | 33 | const struct ide_port_ops *port_ops = hwif->port_ops; |
34 | ide_task_t task; | 34 | struct ide_cmd cmd; |
35 | 35 | ||
36 | if (port_ops && port_ops->selectproc) | 36 | if (port_ops && port_ops->selectproc) |
37 | port_ops->selectproc(drive); | 37 | port_ops->selectproc(drive); |
38 | 38 | ||
39 | memset(&task, 0, sizeof(task)); | 39 | memset(&cmd, 0, sizeof(cmd)); |
40 | task.tf_flags = IDE_TFLAG_OUT_DEVICE; | 40 | cmd.tf_flags = IDE_TFLAG_OUT_DEVICE; |
41 | 41 | ||
42 | drive->hwif->tp_ops->tf_load(drive, &task); | 42 | drive->hwif->tp_ops->tf_load(drive, &cmd); |
43 | } | 43 | } |
44 | 44 | ||
45 | void SELECT_MASK(ide_drive_t *drive, int mask) | 45 | void SELECT_MASK(ide_drive_t *drive, int mask) |
@@ -52,14 +52,14 @@ void SELECT_MASK(ide_drive_t *drive, int mask) | |||
52 | 52 | ||
53 | u8 ide_read_error(ide_drive_t *drive) | 53 | u8 ide_read_error(ide_drive_t *drive) |
54 | { | 54 | { |
55 | ide_task_t task; | 55 | struct ide_cmd cmd; |
56 | 56 | ||
57 | memset(&task, 0, sizeof(task)); | 57 | memset(&cmd, 0, sizeof(cmd)); |
58 | task.tf_flags = IDE_TFLAG_IN_FEATURE; | 58 | cmd.tf_flags = IDE_TFLAG_IN_FEATURE; |
59 | 59 | ||
60 | drive->hwif->tp_ops->tf_read(drive, &task); | 60 | drive->hwif->tp_ops->tf_read(drive, &cmd); |
61 | 61 | ||
62 | return task.tf.error; | 62 | return cmd.tf.error; |
63 | } | 63 | } |
64 | EXPORT_SYMBOL_GPL(ide_read_error); | 64 | EXPORT_SYMBOL_GPL(ide_read_error); |
65 | 65 | ||
@@ -329,7 +329,7 @@ int ide_config_drive_speed(ide_drive_t *drive, u8 speed) | |||
329 | u16 *id = drive->id, i; | 329 | u16 *id = drive->id, i; |
330 | int error = 0; | 330 | int error = 0; |
331 | u8 stat; | 331 | u8 stat; |
332 | ide_task_t task; | 332 | struct ide_cmd cmd; |
333 | 333 | ||
334 | #ifdef CONFIG_BLK_DEV_IDEDMA | 334 | #ifdef CONFIG_BLK_DEV_IDEDMA |
335 | if (hwif->dma_ops) /* check if host supports DMA */ | 335 | if (hwif->dma_ops) /* check if host supports DMA */ |
@@ -361,12 +361,12 @@ int ide_config_drive_speed(ide_drive_t *drive, u8 speed) | |||
361 | udelay(1); | 361 | udelay(1); |
362 | tp_ops->set_irq(hwif, 0); | 362 | tp_ops->set_irq(hwif, 0); |
363 | 363 | ||
364 | memset(&task, 0, sizeof(task)); | 364 | memset(&cmd, 0, sizeof(cmd)); |
365 | task.tf_flags = IDE_TFLAG_OUT_FEATURE | IDE_TFLAG_OUT_NSECT; | 365 | cmd.tf_flags = IDE_TFLAG_OUT_FEATURE | IDE_TFLAG_OUT_NSECT; |
366 | task.tf.feature = SETFEATURES_XFER; | 366 | cmd.tf.feature = SETFEATURES_XFER; |
367 | task.tf.nsect = speed; | 367 | cmd.tf.nsect = speed; |
368 | 368 | ||
369 | tp_ops->tf_load(drive, &task); | 369 | tp_ops->tf_load(drive, &cmd); |
370 | 370 | ||
371 | tp_ops->exec_command(hwif, ATA_CMD_SET_FEATURES); | 371 | tp_ops->exec_command(hwif, ATA_CMD_SET_FEATURES); |
372 | 372 | ||