diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2009-03-31 14:15:31 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:31 -0400 |
commit | 35218d1ca808ed19b8c6f079ce91872b3deb2219 (patch) | |
tree | 4cc1748e9046ef26701c88b3c6448734f1a7e874 /drivers/ide/ide-io-std.c | |
parent | bac08cee93f9cb37b40ecfa8eaf1f6d8daf3909b (diff) |
ide: move data register access out of tf_{read|load}() methods (take 2)
Move IDE_FTFLAG_{IN|OUT}_DATA flag handling out of tf_{read|load}() methods
into the only two functions where these flags actually need to be handled:
do_rw_taskfile() and ide_complete_cmd()...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-io-std.c')
-rw-r--r-- | drivers/ide/ide-io-std.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/drivers/ide/ide-io-std.c b/drivers/ide/ide-io-std.c index f06940df255e..7f77bb7db488 100644 --- a/drivers/ide/ide-io-std.c +++ b/drivers/ide/ide-io-std.c | |||
@@ -90,12 +90,6 @@ void ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) | |||
90 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) | 90 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) |
91 | HIHI = 0xFF; | 91 | HIHI = 0xFF; |
92 | 92 | ||
93 | if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) { | ||
94 | u8 data[2] = { tf->data, tf->hob_data }; | ||
95 | |||
96 | ide_output_data(drive, cmd, data, 2); | ||
97 | } | ||
98 | |||
99 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) | 93 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) |
100 | tf_outb(tf->hob_feature, io_ports->feature_addr); | 94 | tf_outb(tf->hob_feature, io_ports->feature_addr); |
101 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT) | 95 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT) |
@@ -141,15 +135,6 @@ void ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd) | |||
141 | tf_inb = ide_inb; | 135 | tf_inb = ide_inb; |
142 | } | 136 | } |
143 | 137 | ||
144 | if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { | ||
145 | u8 data[2]; | ||
146 | |||
147 | ide_input_data(drive, cmd, data, 2); | ||
148 | |||
149 | tf->data = data[0]; | ||
150 | tf->hob_data = data[1]; | ||
151 | } | ||
152 | |||
153 | /* be sure we're looking at the low order bits */ | 138 | /* be sure we're looking at the low order bits */ |
154 | tf_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr); | 139 | tf_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr); |
155 | 140 | ||