diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2009-04-08 08:13:02 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-04-08 08:13:02 -0400 |
commit | 4109d19af73826aa6fee1a1b951670381be88f8b (patch) | |
tree | 345093962cee2b99228f39a467020d2b0dd5572d /drivers/ide/ide-io-std.c | |
parent | 745483f10c6cefb303007c6873e2bfce54efa8ed (diff) |
ide: move common code out of tf_load() method
Move device register masking (and setting drive->select) out of tf_load() method
and into the only function that needs to use this code, do_rw_taskfile()...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
[bart: fix whitespace error]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-io-std.c')
-rw-r--r-- | drivers/ide/ide-io-std.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/ide/ide-io-std.c b/drivers/ide/ide-io-std.c index 45a424b60c85..7950b3bb4312 100644 --- a/drivers/ide/ide-io-std.c +++ b/drivers/ide/ide-io-std.c | |||
@@ -93,16 +93,12 @@ void ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) | |||
93 | void (*tf_outb)(u8 addr, unsigned long port); | 93 | void (*tf_outb)(u8 addr, unsigned long port); |
94 | u8 valid = cmd->valid.out.hob; | 94 | u8 valid = cmd->valid.out.hob; |
95 | u8 mmio = (hwif->host_flags & IDE_HFLAG_MMIO) ? 1 : 0; | 95 | u8 mmio = (hwif->host_flags & IDE_HFLAG_MMIO) ? 1 : 0; |
96 | u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF; | ||
97 | 96 | ||
98 | if (mmio) | 97 | if (mmio) |
99 | tf_outb = ide_mm_outb; | 98 | tf_outb = ide_mm_outb; |
100 | else | 99 | else |
101 | tf_outb = ide_outb; | 100 | tf_outb = ide_outb; |
102 | 101 | ||
103 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) | ||
104 | HIHI = 0xFF; | ||
105 | |||
106 | if (valid & IDE_VALID_FEATURE) | 102 | if (valid & IDE_VALID_FEATURE) |
107 | tf_outb(tf->feature, io_ports->feature_addr); | 103 | tf_outb(tf->feature, io_ports->feature_addr); |
108 | if (valid & IDE_VALID_NSECT) | 104 | if (valid & IDE_VALID_NSECT) |
@@ -127,10 +123,8 @@ void ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) | |||
127 | tf_outb(tf->lbam, io_ports->lbam_addr); | 123 | tf_outb(tf->lbam, io_ports->lbam_addr); |
128 | if (valid & IDE_VALID_LBAH) | 124 | if (valid & IDE_VALID_LBAH) |
129 | tf_outb(tf->lbah, io_ports->lbah_addr); | 125 | tf_outb(tf->lbah, io_ports->lbah_addr); |
130 | |||
131 | if (valid & IDE_VALID_DEVICE) | 126 | if (valid & IDE_VALID_DEVICE) |
132 | tf_outb((tf->device & HIHI) | drive->select, | 127 | tf_outb(tf->device, io_ports->device_addr); |
133 | io_ports->device_addr); | ||
134 | } | 128 | } |
135 | EXPORT_SYMBOL_GPL(ide_tf_load); | 129 | EXPORT_SYMBOL_GPL(ide_tf_load); |
136 | 130 | ||