diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2009-03-31 14:15:31 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:31 -0400 |
commit | bac08cee93f9cb37b40ecfa8eaf1f6d8daf3909b (patch) | |
tree | e3a5a3dd993077d64e16699e866e37ad66d652c8 /drivers/ide/ide-h8300.c | |
parent | deae17fd5d147ae65e277905343b7ea578574d12 (diff) |
ide: call {in|out}put_data() methods from tf_{read|load}() methods (take 2)
Handle IDE_FTFLAG_{IN|OUT}_DATA flags in tf_{read|load}() methods by calling
{in|out}put_data() methods to transfer 2 bytes -- this will allow us to move
that handling out of those methods altogether...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-h8300.c')
-rw-r--r-- | drivers/ide/ide-h8300.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/ide/ide-h8300.c b/drivers/ide/ide-h8300.c index 1d45cd5b6a1c..6cb1785d32e6 100644 --- a/drivers/ide/ide-h8300.c +++ b/drivers/ide/ide-h8300.c | |||
@@ -54,8 +54,11 @@ static void h8300_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) | |||
54 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) | 54 | if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED) |
55 | HIHI = 0xFF; | 55 | HIHI = 0xFF; |
56 | 56 | ||
57 | if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) | 57 | if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) { |
58 | mm_outw((tf->hob_data << 8) | tf->data, io_ports->data_addr); | 58 | u8 data[2] = { tf->data, tf->hob_data }; |
59 | |||
60 | h8300_output_data(drive, cmd, data, 2); | ||
61 | } | ||
59 | 62 | ||
60 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) | 63 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) |
61 | outb(tf->hob_feature, io_ports->feature_addr); | 64 | outb(tf->hob_feature, io_ports->feature_addr); |
@@ -91,10 +94,12 @@ static void h8300_tf_read(ide_drive_t *drive, struct ide_cmd *cmd) | |||
91 | struct ide_taskfile *tf = &cmd->tf; | 94 | struct ide_taskfile *tf = &cmd->tf; |
92 | 95 | ||
93 | if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { | 96 | if (cmd->ftf_flags & IDE_FTFLAG_IN_DATA) { |
94 | u16 data = mm_inw(io_ports->data_addr); | 97 | u8 data[2]; |
98 | |||
99 | h8300_input_data(drive, cmd, data, 2); | ||
95 | 100 | ||
96 | tf->data = data & 0xff; | 101 | tf->data = data[0]; |
97 | tf->hob_data = (data >> 8) & 0xff; | 102 | tf->hob_data = data[1]; |
98 | } | 103 | } |
99 | 104 | ||
100 | /* be sure we're looking at the low order bits */ | 105 | /* be sure we're looking at the low order bits */ |