aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ide/ide-floppy.c
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-03-31 14:15:25 -0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-03-31 14:15:25 -0400
commit41fa9f863baacd32dd049daf8050d55a0c9e6f1a (patch)
tree44cc612753746cd459e122f102c72f33b36aa6b7 /drivers/ide/ide-floppy.c
parentb5479167f4206e0d821a51ae149d921cd7a58e54 (diff)
ide: decrease size of ->pc_buf field in struct ide_atapi_pc
struct ide_atapi_pc is often allocated on the stack and size of ->pc_buf size is 256 bytes. However since only ide_floppy_create_read_capacity_cmd() and idetape_create_inquiry_cmd() require such size allocate buffers for these pc-s explicitely and decrease ->pc_buf size to 64 bytes. Cc: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-floppy.c')
-rw-r--r--drivers/ide/ide-floppy.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 7ae662334835..0faae3098295 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -385,7 +385,7 @@ static int ide_floppy_get_capacity(ide_drive_t *drive)
385 struct gendisk *disk = floppy->disk; 385 struct gendisk *disk = floppy->disk;
386 struct ide_atapi_pc pc; 386 struct ide_atapi_pc pc;
387 u8 *cap_desc; 387 u8 *cap_desc;
388 u8 header_len, desc_cnt; 388 u8 pc_buf[256], header_len, desc_cnt;
389 int i, rc = 1, blocks, length; 389 int i, rc = 1, blocks, length;
390 390
391 drive->bios_cyl = 0; 391 drive->bios_cyl = 0;
@@ -395,6 +395,9 @@ static int ide_floppy_get_capacity(ide_drive_t *drive)
395 drive->capacity64 = 0; 395 drive->capacity64 = 0;
396 396
397 ide_floppy_create_read_capacity_cmd(&pc); 397 ide_floppy_create_read_capacity_cmd(&pc);
398 pc.buf = &pc_buf[0];
399 pc.buf_size = sizeof(pc_buf);
400
398 if (ide_queue_pc_tail(drive, disk, &pc)) { 401 if (ide_queue_pc_tail(drive, disk, &pc)) {
399 printk(KERN_ERR PFX "Can't get floppy parameters\n"); 402 printk(KERN_ERR PFX "Can't get floppy parameters\n");
400 return 1; 403 return 1;