diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:46 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:46 -0400 |
commit | 60c0cd02b254805691cdc61101ada6af7bd56fde (patch) | |
tree | 1b600eb9f22034824bf21377041f470c09af09c7 /drivers/ide/ide-eh.c | |
parent | b788ee9c6561fd9219a503216284d61036a0dc0b (diff) |
ide: set hwif->expiry prior to calling [__]ide_set_handler()
* Set hwif->expiry prior to calling [__]ide_set_handler()
and drop 'expiry' argument.
* Set hwif->expiry to NULL in ide_{timer_expiry,intr}()
and remove 'hwif->expiry = NULL' assignments.
There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-eh.c')
-rw-r--r-- | drivers/ide/ide-eh.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/ide/ide-eh.c b/drivers/ide/ide-eh.c index aff1a9b04559..11664976eea3 100644 --- a/drivers/ide/ide-eh.c +++ b/drivers/ide/ide-eh.c | |||
@@ -175,8 +175,7 @@ static ide_startstop_t atapi_reset_pollfunc(ide_drive_t *drive) | |||
175 | printk(KERN_INFO "%s: ATAPI reset complete\n", drive->name); | 175 | printk(KERN_INFO "%s: ATAPI reset complete\n", drive->name); |
176 | else { | 176 | else { |
177 | if (time_before(jiffies, hwif->poll_timeout)) { | 177 | if (time_before(jiffies, hwif->poll_timeout)) { |
178 | ide_set_handler(drive, &atapi_reset_pollfunc, HZ/20, | 178 | ide_set_handler(drive, &atapi_reset_pollfunc, HZ/20); |
179 | NULL); | ||
180 | /* continue polling */ | 179 | /* continue polling */ |
181 | return ide_started; | 180 | return ide_started; |
182 | } | 181 | } |
@@ -238,7 +237,7 @@ static ide_startstop_t reset_pollfunc(ide_drive_t *drive) | |||
238 | 237 | ||
239 | if (!OK_STAT(tmp, 0, ATA_BUSY)) { | 238 | if (!OK_STAT(tmp, 0, ATA_BUSY)) { |
240 | if (time_before(jiffies, hwif->poll_timeout)) { | 239 | if (time_before(jiffies, hwif->poll_timeout)) { |
241 | ide_set_handler(drive, &reset_pollfunc, HZ/20, NULL); | 240 | ide_set_handler(drive, &reset_pollfunc, HZ/20); |
242 | /* continue polling */ | 241 | /* continue polling */ |
243 | return ide_started; | 242 | return ide_started; |
244 | } | 243 | } |
@@ -355,7 +354,7 @@ static ide_startstop_t do_reset1(ide_drive_t *drive, int do_not_try_atapi) | |||
355 | ndelay(400); | 354 | ndelay(400); |
356 | hwif->poll_timeout = jiffies + WAIT_WORSTCASE; | 355 | hwif->poll_timeout = jiffies + WAIT_WORSTCASE; |
357 | hwif->polling = 1; | 356 | hwif->polling = 1; |
358 | __ide_set_handler(drive, &atapi_reset_pollfunc, HZ/20, NULL); | 357 | __ide_set_handler(drive, &atapi_reset_pollfunc, HZ/20); |
359 | spin_unlock_irqrestore(&hwif->lock, flags); | 358 | spin_unlock_irqrestore(&hwif->lock, flags); |
360 | return ide_started; | 359 | return ide_started; |
361 | } | 360 | } |
@@ -415,7 +414,7 @@ static ide_startstop_t do_reset1(ide_drive_t *drive, int do_not_try_atapi) | |||
415 | udelay(10); | 414 | udelay(10); |
416 | hwif->poll_timeout = jiffies + WAIT_WORSTCASE; | 415 | hwif->poll_timeout = jiffies + WAIT_WORSTCASE; |
417 | hwif->polling = 1; | 416 | hwif->polling = 1; |
418 | __ide_set_handler(drive, &reset_pollfunc, HZ/20, NULL); | 417 | __ide_set_handler(drive, &reset_pollfunc, HZ/20); |
419 | 418 | ||
420 | /* | 419 | /* |
421 | * Some weird controller like resetting themselves to a strange | 420 | * Some weird controller like resetting themselves to a strange |