diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2007-07-09 17:17:54 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2007-07-09 17:17:54 -0400 |
commit | 841d2a9bf16471716ba3a5172d24aa40a2ea9398 (patch) | |
tree | f836d41ed70bf3efd6350c293c0c31a40ef4f900 /drivers/ide/ide-dma.c | |
parent | b740d8846e2e184909e9f74d4ad9d67ae0e084ea (diff) |
ide: make void and rename ide_dma_lostirq() method
Since ide_dma_lostirq() method's result is discarded, make it return 'void'.
While at it, rename the method to dma_lost_irq(), drop the '__' prefix from the
default method's name, and do some cleanups in this method driver-wise:
- in aec62xx.c, rename the method in accordance with other drivers, and get rid
of unnecessary variables there;
- in pdc202xx_old.c, define/use 'hwif' variable;
- in sgiioc4.c, rearrange the code to call the resetproc() method directly.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-dma.c')
-rw-r--r-- | drivers/ide/ide-dma.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c index ead141e2db9e..ce322602982e 100644 --- a/drivers/ide/ide-dma.c +++ b/drivers/ide/ide-dma.c | |||
@@ -850,13 +850,12 @@ int ide_set_dma(ide_drive_t *drive) | |||
850 | EXPORT_SYMBOL_GPL(ide_set_dma); | 850 | EXPORT_SYMBOL_GPL(ide_set_dma); |
851 | 851 | ||
852 | #ifdef CONFIG_BLK_DEV_IDEDMA_PCI | 852 | #ifdef CONFIG_BLK_DEV_IDEDMA_PCI |
853 | int __ide_dma_lostirq (ide_drive_t *drive) | 853 | void ide_dma_lost_irq (ide_drive_t *drive) |
854 | { | 854 | { |
855 | printk("%s: DMA interrupt recovery\n", drive->name); | 855 | printk("%s: DMA interrupt recovery\n", drive->name); |
856 | return 1; | ||
857 | } | 856 | } |
858 | 857 | ||
859 | EXPORT_SYMBOL(__ide_dma_lostirq); | 858 | EXPORT_SYMBOL(ide_dma_lost_irq); |
860 | 859 | ||
861 | int __ide_dma_timeout (ide_drive_t *drive) | 860 | int __ide_dma_timeout (ide_drive_t *drive) |
862 | { | 861 | { |
@@ -1020,8 +1019,8 @@ void ide_setup_dma (ide_hwif_t *hwif, unsigned long dma_base, unsigned int num_p | |||
1020 | hwif->ide_dma_test_irq = &__ide_dma_test_irq; | 1019 | hwif->ide_dma_test_irq = &__ide_dma_test_irq; |
1021 | if (!hwif->ide_dma_timeout) | 1020 | if (!hwif->ide_dma_timeout) |
1022 | hwif->ide_dma_timeout = &__ide_dma_timeout; | 1021 | hwif->ide_dma_timeout = &__ide_dma_timeout; |
1023 | if (!hwif->ide_dma_lostirq) | 1022 | if (!hwif->dma_lost_irq) |
1024 | hwif->ide_dma_lostirq = &__ide_dma_lostirq; | 1023 | hwif->dma_lost_irq = &ide_dma_lost_irq; |
1025 | 1024 | ||
1026 | if (hwif->chipset != ide_trm290) { | 1025 | if (hwif->chipset != ide_trm290) { |
1027 | u8 dma_stat = hwif->INB(hwif->dma_status); | 1026 | u8 dma_stat = hwif->INB(hwif->dma_status); |