diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-10-10 16:39:27 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-10-10 16:39:27 -0400 |
commit | 263138a0ad6e38de7f6526b7de037ed4511308ef (patch) | |
tree | 1da68f098b378ddf2381c2012d700c897c6681ee /drivers/ide/ide-disk.c | |
parent | 1e874f448365b80e69b8a60b8b575b17f00811f3 (diff) |
ide: preparations for /proc/ide/hd*/settings rework
After rework settings will be no longer created dynamically
for each device so we need to make some fixups first.
* Use set_[ksettings,unmaskirq]() as a set function for
["keepsettings","unmaskirq"] setting.
* Allow writes to ["io_32bit","unmaskirq"] settings also when
drive->no_[io_32bit,unmask] is set (this is checked later inside
set_[io_32bit,unmaskirq]() anywyay and keeps consistency with
the corresponding HDIO_SET_[32BIT,UNMASKINTR] ioctls).
* Use max possible multi sectors value (16) as an allowed max for
"multcount" setting. set_multcount() set function checks against
device's max possbile value anyway and it makes the proc setting
consistent with the corresponding HDIO_SET_MULTCOUNT ioctl.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-disk.c')
-rw-r--r-- | drivers/ide/ide-disk.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c index 5fc4213437a5..7a15907dce1d 100644 --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c | |||
@@ -760,8 +760,7 @@ static void idedisk_add_settings(ide_drive_t *drive) | |||
760 | &drive->bios_sect, NULL); | 760 | &drive->bios_sect, NULL); |
761 | ide_add_setting(drive, "address", SETTING_RW, TYPE_BYTE, 0, 2, 1, 1, | 761 | ide_add_setting(drive, "address", SETTING_RW, TYPE_BYTE, 0, 2, 1, 1, |
762 | &drive->addressing, set_lba_addressing); | 762 | &drive->addressing, set_lba_addressing); |
763 | ide_add_setting(drive, "multcount", SETTING_RW, TYPE_BYTE, 0, | 763 | ide_add_setting(drive, "multcount", SETTING_RW, TYPE_BYTE, 0, 16, 1, 1, |
764 | drive->id[ATA_ID_MAX_MULTSECT] & 0xff, 1, 1, | ||
765 | &drive->mult_count, set_multcount); | 764 | &drive->mult_count, set_multcount); |
766 | ide_add_setting(drive, "nowerr", SETTING_RW, TYPE_BYTE, 0, 1, 1, 1, | 765 | ide_add_setting(drive, "nowerr", SETTING_RW, TYPE_BYTE, 0, 1, 1, 1, |
767 | &drive->nowerr, set_nowerr); | 766 | &drive->nowerr, set_nowerr); |