diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
commit | 22aa4b32a19b1f231d4ce7e9af6354b577a22a35 (patch) | |
tree | 3e773e7102e4ea6bb6b4c00edce442c4e8f37edb /drivers/ide/ide-atapi.c | |
parent | e6830a86c260d73c6f370aa7ed17ee6c71e5ee05 (diff) |
ide: remove ide_task_t typedef
While at it:
- rename struct ide_task_s to struct ide_cmd
- remove stale comments from idedisk_{read_native,set}_max_address()
- drop unused 'cmd' argument from ide_{cmd,task}_ioctl()
- drop unused 'task' argument from tx4939ide_tf_load_fixup()
- rename ide_complete_task() to ide_complete_cmd()
- use consistent naming for struct ide_cmd variables
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-atapi.c')
-rw-r--r-- | drivers/ide/ide-atapi.c | 42 |
1 files changed, 21 insertions, 21 deletions
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c index 2b9ac2106674..92c6ef6feb57 100644 --- a/drivers/ide/ide-atapi.c +++ b/drivers/ide/ide-atapi.c | |||
@@ -302,16 +302,16 @@ EXPORT_SYMBOL_GPL(ide_cd_get_xferlen); | |||
302 | 302 | ||
303 | void ide_read_bcount_and_ireason(ide_drive_t *drive, u16 *bcount, u8 *ireason) | 303 | void ide_read_bcount_and_ireason(ide_drive_t *drive, u16 *bcount, u8 *ireason) |
304 | { | 304 | { |
305 | ide_task_t task; | 305 | struct ide_cmd cmd; |
306 | 306 | ||
307 | memset(&task, 0, sizeof(task)); | 307 | memset(&cmd, 0, sizeof(cmd)); |
308 | task.tf_flags = IDE_TFLAG_IN_LBAH | IDE_TFLAG_IN_LBAM | | 308 | cmd.tf_flags = IDE_TFLAG_IN_LBAH | IDE_TFLAG_IN_LBAM | |
309 | IDE_TFLAG_IN_NSECT; | 309 | IDE_TFLAG_IN_NSECT; |
310 | 310 | ||
311 | drive->hwif->tp_ops->tf_read(drive, &task); | 311 | drive->hwif->tp_ops->tf_read(drive, &cmd); |
312 | 312 | ||
313 | *bcount = (task.tf.lbah << 8) | task.tf.lbam; | 313 | *bcount = (cmd.tf.lbah << 8) | cmd.tf.lbam; |
314 | *ireason = task.tf.nsect & 3; | 314 | *ireason = cmd.tf.nsect & 3; |
315 | } | 315 | } |
316 | EXPORT_SYMBOL_GPL(ide_read_bcount_and_ireason); | 316 | EXPORT_SYMBOL_GPL(ide_read_bcount_and_ireason); |
317 | 317 | ||
@@ -482,32 +482,32 @@ next_irq: | |||
482 | static void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount) | 482 | static void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount) |
483 | { | 483 | { |
484 | ide_hwif_t *hwif = drive->hwif; | 484 | ide_hwif_t *hwif = drive->hwif; |
485 | ide_task_t task; | 485 | struct ide_cmd cmd; |
486 | u8 dma = drive->dma; | 486 | u8 dma = drive->dma; |
487 | 487 | ||
488 | memset(&task, 0, sizeof(task)); | 488 | memset(&cmd, 0, sizeof(cmd)); |
489 | task.tf_flags = IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM | | 489 | cmd.tf_flags = IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM | |
490 | IDE_TFLAG_OUT_FEATURE | tf_flags; | 490 | IDE_TFLAG_OUT_FEATURE | tf_flags; |
491 | task.tf.feature = dma; /* Use PIO/DMA */ | 491 | cmd.tf.feature = dma; /* Use PIO/DMA */ |
492 | task.tf.lbam = bcount & 0xff; | 492 | cmd.tf.lbam = bcount & 0xff; |
493 | task.tf.lbah = (bcount >> 8) & 0xff; | 493 | cmd.tf.lbah = (bcount >> 8) & 0xff; |
494 | 494 | ||
495 | ide_tf_dump(drive->name, &task.tf); | 495 | ide_tf_dump(drive->name, &cmd.tf); |
496 | hwif->tp_ops->set_irq(hwif, 1); | 496 | hwif->tp_ops->set_irq(hwif, 1); |
497 | SELECT_MASK(drive, 0); | 497 | SELECT_MASK(drive, 0); |
498 | hwif->tp_ops->tf_load(drive, &task); | 498 | hwif->tp_ops->tf_load(drive, &cmd); |
499 | } | 499 | } |
500 | 500 | ||
501 | static u8 ide_read_ireason(ide_drive_t *drive) | 501 | static u8 ide_read_ireason(ide_drive_t *drive) |
502 | { | 502 | { |
503 | ide_task_t task; | 503 | struct ide_cmd cmd; |
504 | 504 | ||
505 | memset(&task, 0, sizeof(task)); | 505 | memset(&cmd, 0, sizeof(cmd)); |
506 | task.tf_flags = IDE_TFLAG_IN_NSECT; | 506 | cmd.tf_flags = IDE_TFLAG_IN_NSECT; |
507 | 507 | ||
508 | drive->hwif->tp_ops->tf_read(drive, &task); | 508 | drive->hwif->tp_ops->tf_read(drive, &cmd); |
509 | 509 | ||
510 | return task.tf.nsect & 3; | 510 | return cmd.tf.nsect & 3; |
511 | } | 511 | } |
512 | 512 | ||
513 | static u8 ide_wait_ireason(ide_drive_t *drive, u8 ireason) | 513 | static u8 ide_wait_ireason(ide_drive_t *drive, u8 ireason) |