diff options
author | Borislav Petkov <petkovbb@gmail.com> | 2009-06-07 09:37:05 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-06-07 09:37:05 -0400 |
commit | 626542ca2277961aaa64855206574f8ca4f360e3 (patch) | |
tree | 88f2071580dbe02c43741dd112d8f7b98eea0938 /drivers/ide/ide-atapi.c | |
parent | ffddf1717b0d388879c646eaf6261a2b393c06ad (diff) |
ide-tape: change IDE_AFLAG_IGNORE_DSC non-atomically
There are two sites where the flag is being changed: ide_retry_pc
and idetape_do_request. Both codepaths are protected by hwif->busy
(ide_lock_port) and therefore we shouldn't need the atomic accesses.
Spotted-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-atapi.c')
-rw-r--r-- | drivers/ide/ide-atapi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c index afe5a4323879..fbcb8513a4c8 100644 --- a/drivers/ide/ide-atapi.c +++ b/drivers/ide/ide-atapi.c | |||
@@ -258,7 +258,7 @@ void ide_retry_pc(ide_drive_t *drive) | |||
258 | pc->req_xfer = sense_rq->data_len; | 258 | pc->req_xfer = sense_rq->data_len; |
259 | 259 | ||
260 | if (drive->media == ide_tape) | 260 | if (drive->media == ide_tape) |
261 | set_bit(IDE_AFLAG_IGNORE_DSC, &drive->atapi_flags); | 261 | drive->atapi_flags |= IDE_AFLAG_IGNORE_DSC; |
262 | 262 | ||
263 | if (ide_queue_sense_rq(drive, pc)) | 263 | if (ide_queue_sense_rq(drive, pc)) |
264 | ide_complete_rq(drive, -EIO, blk_rq_bytes(drive->hwif->rq)); | 264 | ide_complete_rq(drive, -EIO, blk_rq_bytes(drive->hwif->rq)); |