diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:45 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:45 -0400 |
commit | 130e886708d6e11f3d54e5d27c266578de56f343 (patch) | |
tree | af6c09224bd1aa21119c052cd3664719916ec795 /drivers/ide/ide-atapi.c | |
parent | ba7d479c36dde12821c01ad0696d678635b8fb92 (diff) |
ide: remove ide_end_request()
* Add ide_rq_bytes() helper.
* Add blk_noretry_request() quirk to ide_complete_rq() (currently only fs
requests can be marked as "noretry" so there is no change in behavior).
* Switch current ide_end_request() users to use ide_complete_rq().
[ No need to check for rq->nr_sectors == 0 in {ide_dma,task_pio}_intr(),
nsectors == 0 in cdrom_end_request() and err == 0 in ide_do_devset(). ]
* Remove no longer needed ide_end_request().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-atapi.c')
-rw-r--r-- | drivers/ide/ide-atapi.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c index 30156aa61016..c3fd528a1b4d 100644 --- a/drivers/ide/ide-atapi.c +++ b/drivers/ide/ide-atapi.c | |||
@@ -410,7 +410,8 @@ static ide_startstop_t ide_pc_intr(ide_drive_t *drive) | |||
410 | if (rq->errors == 0) | 410 | if (rq->errors == 0) |
411 | rq->errors = -EIO; | 411 | rq->errors = -EIO; |
412 | } | 412 | } |
413 | ide_end_request(drive, uptodate, 0); | 413 | ide_complete_rq(drive, uptodate ? 0 : -EIO, |
414 | ide_rq_bytes(rq)); | ||
414 | } | 415 | } |
415 | 416 | ||
416 | return ide_stopped; | 417 | return ide_stopped; |
@@ -469,7 +470,8 @@ static ide_startstop_t ide_pc_intr(ide_drive_t *drive) | |||
469 | 470 | ||
470 | /* FIXME: don't do partial completions */ | 471 | /* FIXME: don't do partial completions */ |
471 | if (drive->media == ide_floppy) | 472 | if (drive->media == ide_floppy) |
472 | ide_end_request(drive, 1, done >> 9); | 473 | ide_complete_rq(drive, 0, |
474 | done ? done : ide_rq_bytes(rq)); | ||
473 | } else | 475 | } else |
474 | xferfunc(drive, NULL, pc->cur_pos, bcount); | 476 | xferfunc(drive, NULL, pc->cur_pos, bcount); |
475 | 477 | ||