diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-24 18:22:53 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-24 18:22:53 -0400 |
commit | 2ed0ef543ae3f3ea4f8bd0433fb1fed22625a309 (patch) | |
tree | 44777820dcef08ed0fc4b9583bf982220ba15154 /drivers/ide/hpt366.c | |
parent | a182807a89946bd531122bb2da60fa9ceee90343 (diff) |
ide: fix ->init_chipset method to return 'int' value
* Return 0 instead of dev->irq in ->init_chipset implementations.
* Fix ->init_chipset method to return 'int' value instead of
'unsigned int' one.
This fixes ->init_chipset handling for host drivers (cs5530, hpt366
and pdc202xx_new) for which it is possible for this method to fail.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/hpt366.c')
-rw-r--r-- | drivers/ide/hpt366.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c index 3eb9b5c63a0f..d3b3e824f445 100644 --- a/drivers/ide/hpt366.c +++ b/drivers/ide/hpt366.c | |||
@@ -995,7 +995,7 @@ static void hpt3xx_disable_fast_irq(struct pci_dev *dev, u8 mcr_addr) | |||
995 | pci_write_config_byte(dev, mcr_addr + 1, new_mcr); | 995 | pci_write_config_byte(dev, mcr_addr + 1, new_mcr); |
996 | } | 996 | } |
997 | 997 | ||
998 | static unsigned int init_chipset_hpt366(struct pci_dev *dev) | 998 | static int init_chipset_hpt366(struct pci_dev *dev) |
999 | { | 999 | { |
1000 | unsigned long io_base = pci_resource_start(dev, 4); | 1000 | unsigned long io_base = pci_resource_start(dev, 4); |
1001 | struct hpt_info *info = hpt3xx_get_info(&dev->dev); | 1001 | struct hpt_info *info = hpt3xx_get_info(&dev->dev); |
@@ -1237,7 +1237,7 @@ static unsigned int init_chipset_hpt366(struct pci_dev *dev) | |||
1237 | hpt3xx_disable_fast_irq(dev, 0x50); | 1237 | hpt3xx_disable_fast_irq(dev, 0x50); |
1238 | hpt3xx_disable_fast_irq(dev, 0x54); | 1238 | hpt3xx_disable_fast_irq(dev, 0x54); |
1239 | 1239 | ||
1240 | return dev->irq; | 1240 | return 0; |
1241 | } | 1241 | } |
1242 | 1242 | ||
1243 | static u8 hpt3xx_cable_detect(ide_hwif_t *hwif) | 1243 | static u8 hpt3xx_cable_detect(ide_hwif_t *hwif) |